Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering Problem #1149

Closed
thomaskkrachten opened this issue Sep 4, 2023 · 5 comments · Fixed by #1150
Closed

Ordering Problem #1149

thomaskkrachten opened this issue Sep 4, 2023 · 5 comments · Fixed by #1150

Comments

@thomaskkrachten
Copy link

Wenn oldest first ausgewählt wird, dann ist die Auflistung July, Juni, Mai, April und wenn newest first dann ist sie umgekehrt. Die Auflistung der Videos passt zu der gewählten Ansicht.

@MariusAlbrecht
Copy link

MariusAlbrecht commented Sep 4, 2023

can confirm. Ordering is the wrong way around.
The html element in question has the css path html.dark.juheove.ykhplhs body.h-screen.flex.flex-col.items-stretch.tum-live-bg main#content.flex.grow.h-full.overflow-y-scroll article.text-3.p-4.grow article.tum-live-course-view div.grid.gap-x-8.xl:grid-cols-3.grid-cols-1 section.tum-live-course-view-item.col-span-full section article.flex.flex-col
and html code <article class="flex flex-col" : class="{'flex-col-reverse' : isOldestFirst()>

The problem seems to be fixed by replacing isOldestFirst() with !isOldestFirst() as is already done in the code

that bit of code just doesnt seem to be online (yet?)

@MatthiasReumann
Copy link
Collaborator

can confirm. Ordering is the wrong way around. The html element in question has the css path html.dark.juheove.ykhplhs body.h-screen.flex.flex-col.items-stretch.tum-live-bg main#content.flex.grow.h-full.overflow-y-scroll article.text-3.p-4.grow article.tum-live-course-view div.grid.gap-x-8.xl:grid-cols-3.grid-cols-1 section.tum-live-course-view-item.col-span-full section article.flex.flex-col and html code <article class="flex flex-col" : class="{'flex-col-reverse' : isOldestFirst()>

The problem seems to be fixed by replacing isOldestFirst() with !isOldestFirst() as is already done in the code

that bit of code just doesnt seem to be online (yet?)

Yes exactly. The problem should be fixed after #1145 is deployed. Thanks for the issue anyways!

@joschahenningsen
Copy link
Member

Just deployed the newest version, should be all good now.

@alexanderstephan
Copy link
Collaborator

Ah, I think it is still broken. It is now only sorted by month, not respecting the year, i.e., January 2023 is before October 2022. E.g, see https://live.rbg.tum.de/?year=2022&term=W&slug=jms&view=3.

@MatthiasReumann
Copy link
Collaborator

https://live.rbg.tum.de/?year=2022&term=W&slug=jms&view=3

Seems to be right. I will try to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants