-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Section Admin Bugs #1125
Merged
Merged
Video Section Admin Bugs #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Testserver will be ready at https://1125.test.live.mm.rbg.tum.de in a few minutes. Logins
|
alexanderstephan
requested changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting to these fixes so quickly! 👍 Firefox really seems to be a diva lately. 😅
I have added some suggestions and remarks.
alexanderstephan
approved these changes
Aug 19, 2023
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
- Resolves deletion of video sections broken #1123 (Allow the deletion of video sections for which no thumbnail exists) - Resolves Input validation for video section timestamps not working on Firefox #1124 (Firefox still allows letters in <input type="number"> fields. Manual validation via regex necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
<input type="number">
fields. Manual validation via regex necessary)Steps for Testing