Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Section Admin Bugs #1125

Merged
merged 8 commits into from
Aug 19, 2023
Merged

Video Section Admin Bugs #1125

merged 8 commits into from
Aug 19, 2023

Conversation

MatthiasReumann
Copy link
Collaborator

Motivation and Context

Steps for Testing

  • 1 Admin
  • 1 Course
  • Firefox
  1. Log in
  2. Navigate to Admin Course Page
  3. Type a letter into one of the number fields. Shouldn't work anymore.
  4. Create Video Section
  5. Publish Video Section
  6. Delete Video Section
  7. 🎉

@github-actions
Copy link

Your Testserver will be ready at https://1125.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Collaborator

@alexanderstephan alexanderstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to these fixes so quickly! 👍 Firefox really seems to be a diva lately. 😅
I have added some suggestions and remarks.

api/stream.go Show resolved Hide resolved
api/stream.go Show resolved Hide resolved
web/router.go Show resolved Hide resolved
@alexanderstephan alexanderstephan merged commit e11b49d into dev Aug 19, 2023
8 checks passed
@alexanderstephan alexanderstephan deleted the bugs/video-section-admin branch August 19, 2023 12:15
SebiWrn pushed a commit that referenced this pull request May 7, 2024
- Resolves deletion of video sections broken #1123 (Allow the deletion of video sections for which no thumbnail exists)
- Resolves Input validation for video section timestamps not working on Firefox #1124 (Firefox still allows letters in <input type="number"> fields. Manual validation via regex necessary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input validation for video section timestamps not working on Firefox Deletion of video sections broken
2 participants