Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change startMinutes to startHours #1127

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

MatthiasReumann
Copy link
Collaborator

Motivation and Context

Introduced in #1125.

Steps for Testing

Prerequisites:

  • 1 Admin
  • 1 Course
  1. Log in
  2. Navigate to a Admin Course Page
  3. Try to insert invalid start hours, minutes, and seconds. (e.g. startMinutes=107)
  4. The "Add" button should be disabled.

@MatthiasReumann MatthiasReumann added the bug Something isn't working label Aug 21, 2023
@github-actions
Copy link

Your Testserver will be ready at https://1127.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Member

@joschahenningsen joschahenningsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@joschahenningsen joschahenningsen merged commit 246f60a into dev Aug 21, 2023
8 checks passed
@joschahenningsen joschahenningsen deleted the bug/video-section-validation branch August 21, 2023 04:23
SebiWrn pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants