Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chat #1147

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Fix chat #1147

merged 2 commits into from
Aug 30, 2023

Conversation

MatthiasReumann
Copy link
Collaborator

Motivation and Context

In #1135 the textarea tag hasn't been closed. As a result the chat UI doesn't work properly. Furthermore, it broke the polls.
(For examples, see testserver of #1145)

Description

Close tag.

Steps for Testing

Prerequisites:

  • 1 Account
  • 1 Livestream
  1. Log in
  2. Navigate to a Livestream
  3. Chat send button should say send and not New Poll.
  4. Polls work.
  5. 🤠

@MatthiasReumann MatthiasReumann added bug Something isn't working priority:high labels Aug 28, 2023
@github-actions
Copy link

Your Testserver will be ready at https://1147.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@MatthiasReumann MatthiasReumann marked this pull request as draft August 28, 2023 05:55
@MatthiasReumann MatthiasReumann marked this pull request as ready for review August 28, 2023 06:19
Copy link
Collaborator

@alexanderstephan alexanderstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works again, thanks! I just noticed though that new lines are stripped server side, so the multi-line textbox is not even that useful right now. 🙈

@alexanderstephan alexanderstephan merged commit 710cc24 into dev Aug 30, 2023
@alexanderstephan alexanderstephan deleted the bug/fix-chat-close-textarea branch August 30, 2023 11:14
SebiWrn pushed a commit that referenced this pull request May 7, 2024
In #1135 the textarea tag hasn't been closed. As a result the chat UI doesn't work properly. Furthermore, it broke the polls. This is fixed by closing the tag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants