Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group order #1150

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fix group order #1150

merged 2 commits into from
Sep 6, 2023

Conversation

MatthiasReumann
Copy link
Collaborator

Motivation and Context

Description

Dictionaries are not really great for ordering (i.e. they don't have a order). Rewrite the group function to return a 2-dimensional array (a array of stream groups starting in the same month and year).

Steps for Testing

  • 1 Course
  1. Log in
  2. Navigate to the course page
  3. Streams should now also be grouped correctly if multiple years occur. (e.g. 2022 December, 2023 January)

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Your Testserver will be ready at https://1150.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Collaborator

@alexanderstephan alexanderstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! 🎉

@alexanderstephan alexanderstephan merged commit 926c79a into dev Sep 6, 2023
9 checks passed
@alexanderstephan alexanderstephan deleted the bug/false-order-year branch September 6, 2023 10:41
SebiWrn pushed a commit that referenced this pull request May 7, 2024
Dictionaries are not really great for ordering (i.e. they don't have an order). Rewrite the group function to return a 2-dimensional array (an array of stream groups starting in the same month and year).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ordering Problem
2 participants