Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Page UI #1152

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Settings Page UI #1152

merged 2 commits into from
Sep 20, 2023

Conversation

MatthiasReumann
Copy link
Collaborator

Motivation and Context

Update settings page UI for consistency with other pages.

Description

  • Update CSS/HTML.
  • Decrease header footprint, i.e. only import files which are absolutely necessary.

Steps for Testing

  • 1 Account
  1. Log in
  2. Navigate to settings page
  3. Update name, playback speed, etc.
  4. Should work
  5. 🚀

Screenshots

Screenshot 2023-09-07 at 07 45 38

@MatthiasReumann MatthiasReumann added enhancement New feature or request UI labels Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Your Testserver will be ready at https://1152.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@alexanderstephan
Copy link
Collaborator

The UI itself looks really good. However, I noticed that the menu disappears in the upper right corner. Is that intended?

Reference:
image

@MatthiasReumann
Copy link
Collaborator Author

The UI itself looks really good. However, I noticed that the menu disappears in the upper right corner. Is that intended?

Reference: image

Yup. Same for the info pages. I thought that it makes sense to minimize the footprint of the go-template (i.e. include .User object) in order to make it more easy to migrate to a REST-only approach.

@alexanderstephan
Copy link
Collaborator

Okay, I see 👍 In any case, people can just use the back button in their browser.

Copy link
Member

@joschahenningsen joschahenningsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@joschahenningsen joschahenningsen merged commit 074f352 into dev Sep 20, 2023
9 checks passed
@joschahenningsen joschahenningsen deleted the enh/settings-page-ui branch September 20, 2023 16:01
SebiWrn pushed a commit that referenced this pull request May 7, 2024
* Update user-settings.gohtml

* Minimize header footprint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants