1175 course import dont ask to leave page all the time #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The import body was a form without a submit, making the webbrowser think that changes have been made without saving. this has been fixed by making the body a <div> instead of a <form> - The EventListener in course-import.ts hasn't been removed even after import has been finished, making the browser ask even when import has been finished. to fix this, I wrote the function separately to first add it during the first step in "notify1" and then remove it in "notify2" when the process is finished.
- The import body was a form without a submit, making the webbrowser think that changes have been made without saving. this has been fixed by making the body a <div> instead of a <form> - The EventListener in course-import.ts hasn't been removed even after import has been finished, making the browser ask even when import has been finished. to fix this, I wrote the function separately to first add it during the first step in "notify1" and then remove it in "notify2" when the process is finished.
|
Your Testserver will be ready at https://1198.test.live.mm.rbg.tum.de in a few minutes. Logins
|
|
Maybe you can add back the two comments to preventDefault() and returnValue that have been there before so we know why these two commands are there |
…ents to the other functions for better readability later on.
DawinYurtseven
requested review from
joschahenningsen and
SebiWrn
and removed request for
SebiWrn
SebiWrn
deleted the
1175_Course_Import_Dont_ask_to_leave_page_all_the_time
branch
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* Reasons for the BeforeUnload events: - The import body was a form without a submit, making the webbrowser think that changes have been made without saving. this has been fixed by making the body a <div> instead of a <form> - The EventListener in course-import.ts hasn't been removed even after import has been finished, making the browser ask even when import has been finished. to fix this, I wrote the function separately to first add it during the first step in "notify1" and then remove it in "notify2" when the process is finished. * Reasons for the BeforeUnload events: - The import body was a form without a submit, making the webbrowser think that changes have been made without saving. this has been fixed by making the body a <div> instead of a <form> - The EventListener in course-import.ts hasn't been removed even after import has been finished, making the browser ask even when import has been finished. to fix this, I wrote the function separately to first add it during the first step in "notify1" and then remove it in "notify2" when the process is finished. * executed "npm run lint-fix" to fix ESLint fails * added comments to newly added function. Will plan on adding more comments to the other functions for better readability later on. * ESLint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem:
The problem was that each time something happened during a Course Import, the browser would ask the user if they wanted to leave the page, which would lead to a refreshed site and no changes saved.
What caused it:
there where two reasons why this happened.
My Fixes: