Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #1214 Playback using link with t=0 does not work #1231

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

YiranDuan721
Copy link
Contributor

Motivation and Context

fixed #1214

Description

Distinguish the behavior of the watchProgress function when the parameter t is set to 0 and when it is not set, so that it matches the description in the comment:

If query parameter 't' is specified, the timestamp given by 't' will be used.

Steps for Testing

  1. Clear website cache
  2. Log in
  3. Navigate to a recording video
  4. Jump to anywhere in the video other than the start
  5. Refresh the page, note that the watch progress has been recorded and can be restored, so that the video resumes at the last progress
  6. Add parameter "t=0" to current url and visit it
  7. See the video plays from the start

Jump to 00:00 when set by parameter t = 0
Copy link

github-actions bot commented Nov 8, 2023

Your Testserver will be ready at https://1231.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Collaborator

@alexanderstephan alexanderstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@alexanderstephan alexanderstephan merged commit bd63a53 into dev Nov 20, 2023
8 checks passed
@alexanderstephan alexanderstephan deleted the 1214-playback-at-t-0 branch November 20, 2023 16:21
SebiWrn pushed a commit that referenced this pull request May 7, 2024
Jump to 00:00 when set by parameter t = 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playback using link with t=0 does not work
2 participants