Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate fachschaft_print.pdf to remove second page on two-page #15

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

JosefSchoenberger
Copy link

According to the MPIC Fachschaft's website, there should be no empty page after the cover page:

The file must contain a cover (without a blank page behind it)

I amended the Makefile to generate a fachschaft_print.pdf as well, which has the second, empty page stripped for two-page theses.

Let me know if you feel like fachschaft_print.pdf should instead be called mpic_fachschaft_print.pdf or something along the line.

@COM8 COM8 self-requested a review September 14, 2023 12:32
@COM8 COM8 self-assigned this Sep 14, 2023
@COM8 COM8 added the enhancement New feature or request label Sep 14, 2023
Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dat häcks grep -sq '^TUM-Dev LaTeX-Thesis-Template: twoside$$' build/main.log; 🤣.

Looks good. Thanks @JosefSchoenberger! The file name is OK.

@COM8 COM8 merged commit 4501bdf into TUM-Dev:master Sep 14, 2023
1 check passed
@JosefSchoenberger
Copy link
Author

Dat häcks grep -sq '^TUM-Dev LaTeX-Thesis-Template: twoside$$' build/main.log; 🤣.

Yeah, it's not elegant, I agree. To be fair though (and for short documentation), there is a reason:
I wanted to keep this as a post-processing step, as not everyone wants to print at the Fachschaft. However, LaTeX has very limited options for transferring information out of it – two, to be precise: In the logfile or by generating a new file entirely. Neither option is particularly nice, but at least the logfile does not clutter the build directory any more. That's why I chose this approach.

Anyway, thanks for merging!

@JosefSchoenberger
Copy link
Author

Oh, also, I just realized I messed up: build/main.log$(OUT)/$(FILE).log in the grep-line. IDK how much you care about it, but you might want to fix that.

(Not that changing these parameters is a good idea, the CI won't upload the correct artifacts anymore if you do so, but anyway, for completeness & cleanness sake...)

COM8 added a commit that referenced this pull request Sep 16, 2023
@COM8 COM8 mentioned this pull request Sep 16, 2023
COM8 added a commit that referenced this pull request Sep 16, 2023
* Fixed log file name

#15 (comment)

* Tmp print build output in the CI

* Fixed CI indent

* Single line CI command

* CI upload artifact update

* Updated actions/checkout to version 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants