Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disclaimer.tex: account for longer names #20

Merged

Conversation

paulhdk
Copy link

@paulhdk paulhdk commented Nov 7, 2023

Hi!

I noticed that my name gets wrapped in disclaimer.tex.

Screenshot 2023-11-07 at 11 40 26

Address this by making the hspace dynamic.

This still bears the risk of line-wrapping for even longer names, so it might be worth considering moving the name to a new line altogether.

Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing it!

@COM8 COM8 self-assigned this Nov 7, 2023
@COM8 COM8 added the bug Something isn't working label Nov 7, 2023
@COM8
Copy link
Member

COM8 commented Nov 7, 2023

For now I think the wrapping for even longer names is an edge case that we do not need to address here (for now) since it affects only so few students.

@COM8 COM8 merged commit c98745b into TUM-Dev:master Nov 7, 2023
1 check passed
@paulhdk paulhdk deleted the account-for-longer-names-in-disclaimer branch November 7, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants