adding is_empty flag for prevent panic #145

kyoto7250 · 2022-04-12T05:58:27Z

close #142

This PR adds ~~offset~~ is_empty flag for preventing panic in a filter.
- this flag looks at the length of the list rather than the offset, so I'll rename it (PS. 2022/04/15)

This bug is caused by a moving ownership in a closure.

Lines 77 to 83 in b13e4bb

    
           fn filterd_candidates(&self) -> impl Iterator<Item = &String> { 
        
               self.candidates.iter().filter(move |c| { 
        
                   (c.starts_with(self.word.to_lowercase().as_str()) 
        
                       || c.starts_with(self.word.to_uppercase().as_str())) 
        
                       && !self.word.is_empty() 
        
               }) 
        
           }

I think if ListState is hidden and input is down or up arrow, then the ListState is not updated, and try to acccess to already moved variable again.

However, I didn't see a problem with the current closure implementation, so I responded by adding a flag to not call the closure if ListState is not displayed.

Thank you in advance.

changelog: Adding is_empty flag for prevent panic.

panic reason is closure move in filterd_candidates if tui::ts PR merged, and component will not need to have offset flag @see: fdehau/tui-rs#408

adding offset for prevent panic

6f38dc9

panic reason is closure move in filterd_candidates if tui::ts PR merged, and component will not need to have offset flag @see: fdehau/tui-rs#408

kyoto7250 changed the title ~~adding offset for prevent panic~~ adding ~~offset~~ is_draw for prevent panic Apr 15, 2022

kyoto7250 changed the title ~~adding ~~offset~~ is_draw for prevent panic~~ adding is_draw flag for prevent panic Apr 15, 2022

kyoto7250 changed the title ~~adding is_draw flag for prevent panic~~ adding is_empty flag for prevent panic Apr 15, 2022

change flag name: offset -> is_empty

b1da623

kyoto7250 force-pushed the fix_#142 branch from 4a52500 to b1da623 Compare April 15, 2022 02:13

kyoto7250 mentioned this pull request Jun 16, 2024

add Pull Requests in gobang's PR kyoto7250/zhobo#5

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding is_empty flag for prevent panic #145

adding is_empty flag for prevent panic #145

kyoto7250 commented Apr 12, 2022 •

edited

Loading

	fn filterd_candidates(&self) -> impl Iterator<Item = &String> {
	self.candidates.iter().filter(move \|c\| {
	(c.starts_with(self.word.to_lowercase().as_str())
	\|\| c.starts_with(self.word.to_uppercase().as_str()))
	&& !self.word.is_empty()
	})
	}

adding is_empty flag for prevent panic #145

Are you sure you want to change the base?

adding is_empty flag for prevent panic #145

Conversation

kyoto7250 commented Apr 12, 2022 • edited Loading

kyoto7250 commented Apr 12, 2022 •

edited

Loading