Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate isn't the same as Copy|Paste - seems counter intuitive #1379

Closed
edhans opened this issue Oct 4, 2024 · 4 comments
Closed

Duplicate isn't the same as Copy|Paste - seems counter intuitive #1379

edhans opened this issue Oct 4, 2024 · 4 comments
Labels
issue: bug Confirmed as a bug in TE3

Comments

@edhans
Copy link

edhans commented Oct 4, 2024

Description

In a model in the service, I used the right-click "Duplicate" item to duplicate a field parameter. It copied the DAX, but not much else. The meta data describing which fields were hidden, sort by properties, and the extended properties for the special Field Parameter sauce were missing. I thought that is just the way it worked.

Co-worker said he never had that issue, and turns out, he uses the Copy|Paste feature. That copies 100% of everything.

Now I am apprehensive about using the Duplicate feature on anything not knowing what properties are not being truly copied.

I thought Duplicate was just a single action to do the same as Copy|Paste. Is it supposed to be and this is a bug, or is it not designed to do that, and if not, why? What is the logic in not replicating everything?

Tabular Editor 3 Version

3.17.0

Screenshots

No response

Steps to Reproduce

No response

Expected behavior

No response

Crash Report

No response

Windows Version

No response

@edhans edhans added the template: issue Issue report created by user, needs to be triaged label Oct 4, 2024
@otykier
Copy link
Collaborator

otykier commented Oct 9, 2024

Thanks for reporting this, Ed. It seems like we have a bug here, because the intention was definitely for Duplicate to be functionally equivalent to Copy/Paste, but without having to touch the clipboard. We'll investigate.

@otykier otykier added issue: bug Confirmed as a bug in TE3 and removed template: issue Issue report created by user, needs to be triaged labels Oct 9, 2024
@otykier
Copy link
Collaborator

otykier commented Dec 11, 2024

Hi Ed,
We've now had a chance to look into this in more details, but unfortunately we're not able to reproduce the issue as you describe. I.e. when we use the "Duplicate" command on a Field parameter table, we see the created copy set up with the exact same metadata (except of course the name of the table itself) as the original table:

image

New table:

image

Perhaps it was a fluke? Let us know if you are still seeing this issue.

@otykier
Copy link
Collaborator

otykier commented Dec 19, 2024

FWIW, we changed the behavior of copy/paste/duplicate slightly in 3.19.0, such that when you copy/paste or duplicate a table, all table references (for example through fully qualified column or measure references) within child objects of that table, including RLS expressions, are automatically updated to match the new name of the table.

I'll close this ticket for now, but feel free to reopen if you encounter any issues with this again.

@otykier otykier closed this as completed Dec 19, 2024
@edhans
Copy link
Author

edhans commented Dec 19, 2024

Thanks. I meant to test this earlier this week. with 3.19 though, when I duplicate a field parameter, all of the metadata is copied so it seems to be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Confirmed as a bug in TE3
Development

No branches or pull requests

2 participants