diff --git a/packages/design-system/src/components/Popover/Popover.cy.tsx b/packages/design-system/src/components/Popover/Popover.cy.tsx
index 3d2131a28d0..a56f8d2cc2c 100644
--- a/packages/design-system/src/components/Popover/Popover.cy.tsx
+++ b/packages/design-system/src/components/Popover/Popover.cy.tsx
@@ -7,8 +7,11 @@ context('', () => {
describe('default', () => {
it('should show a popover', () => {
cy.mount(
-
- Open popover
+ Open popover}
+ >
+ Popover content
,
);
@@ -23,10 +26,16 @@ context('', () => {
Popover content
}>
- {}} data-testid="my.button">
- Open popover
-
+ {}} data-testid="my.button">
+ Open popover
+
+ }
+ >
+ Popover content
,
]}
>
diff --git a/packages/design-system/src/components/Popover/Popover.tsx b/packages/design-system/src/components/Popover/Popover.tsx
index bdca6d35399..d99117659ad 100644
--- a/packages/design-system/src/components/Popover/Popover.tsx
+++ b/packages/design-system/src/components/Popover/Popover.tsx
@@ -12,7 +12,6 @@ import { usePopover } from './usePopover';
import theme from './Popover.module.scss';
type PopoverOptions = {
- popup: ReactNode | ((props: any) => ReactNode);
initialOpen?: boolean;
placement?: Placement;
modal?: boolean;
@@ -23,7 +22,8 @@ type PopoverOptions = {
};
export type PopoverProps = {
- children: ChildOrGenerator;
+ disclosure: ChildOrGenerator;
+ children: ReactNode | ((props: any) => ReactNode);
} & PopoverOptions;
export type PopoverStateReturn = {
@@ -34,7 +34,7 @@ export function Popover({
children,
modal = true,
isFixed = false,
- popup,
+ disclosure,
hasPadding = true,
...restOptions
}: PopoverProps) {
@@ -52,7 +52,7 @@ export function Popover({
return (
<>
- {renderOrClone(children, { ...childrenProps, ref: popover.refs.setReference })}
+ {renderOrClone(disclosure, { ...childrenProps, ref: popover.refs.setReference })}
- {typeof popup === 'function'
- ? popup({ ...popover.getFloatingProps(), setOpen: popover.setOpen })
- : popup}
+ {typeof children === 'function'
+ ? children({ ...popover.getFloatingProps(), setOpen: popover.setOpen })
+ : children}
>
diff --git a/packages/faceted-search/src/components/BasicSearch/BasicSearch.component.test.js b/packages/faceted-search/src/components/BasicSearch/BasicSearch.component.test.js
index d789f8fec46..21ae46344cc 100644
--- a/packages/faceted-search/src/components/BasicSearch/BasicSearch.component.test.js
+++ b/packages/faceted-search/src/components/BasicSearch/BasicSearch.component.test.js
@@ -5,6 +5,8 @@ import { BasicSearch } from './BasicSearch.component';
import { FacetedManager } from '../FacetedManager';
import { USAGE_TRACKING_TAGS } from '../../constants';
+jest.unmock('@talend/design-system');
+
describe('BasicSearch', () => {
const badgeText = {
properties: {