From 9528a05329219e582a75772c8d8cb68e8bf62bdd Mon Sep 17 00:00:00 2001
From: jmfrancois <jmfrancois@talend.com>
Date: Thu, 12 Oct 2023 14:10:47 +0200
Subject: [PATCH] chore: lint forms

---
 .../src/UIForm/Widget/Widget.component.js     |   1 +
 .../fields/Datalist/Datalist.component.js     |   1 +
 .../src/UIForm/fields/Date/Date.component.js  |   1 +
 .../UIForm/fields/Date/DateTime.component.js  |   1 +
 .../src/UIForm/fields/Date/Time.component.js  |   1 +
 .../MultiSelectTag.component.js               |   1 +
 .../ResourcePicker.component.test.js          | 102 ++++++++----------
 .../UIForm/fields/Toggle/Toggle.component.js  |   1 +
 packages/forms/src/UIForm/utils/properties.js |   1 +
 9 files changed, 54 insertions(+), 56 deletions(-)

diff --git a/packages/forms/src/UIForm/Widget/Widget.component.js b/packages/forms/src/UIForm/Widget/Widget.component.js
index 5022be3bcf..b4a84fb29c 100644
--- a/packages/forms/src/UIForm/Widget/Widget.component.js
+++ b/packages/forms/src/UIForm/Widget/Widget.component.js
@@ -9,6 +9,7 @@ import shouldRender from '../utils/condition';
 import theme from './Widget.component.module.scss';
 import { useWidget } from '../context';
 
+// eslint-disable-next-line @typescript-eslint/default-param-last
 function isUpdating(updatingKeys = [], key) {
 	if (updatingKeys.length === 0 || !key) {
 		return false;
diff --git a/packages/forms/src/UIForm/fields/Datalist/Datalist.component.js b/packages/forms/src/UIForm/fields/Datalist/Datalist.component.js
index 9cd71f127e..de27de0dff 100644
--- a/packages/forms/src/UIForm/fields/Datalist/Datalist.component.js
+++ b/packages/forms/src/UIForm/fields/Datalist/Datalist.component.js
@@ -218,6 +218,7 @@ class Datalist extends Component {
 					{...this.state}
 					dataFeature={this.props.schema.dataFeature}
 					className="form-control-container"
+					// eslint-disable-next-line jsx-a11y/no-autofocus
 					autoFocus={this.props.schema.autoFocus}
 					disabled={this.props.schema.disabled || this.props.valueIsUpdating}
 					multiSection={get(this.props, 'schema.options.isMultiSection', false)}
diff --git a/packages/forms/src/UIForm/fields/Date/Date.component.js b/packages/forms/src/UIForm/fields/Date/Date.component.js
index 37c7eef45d..a3c9ef6ca4 100644
--- a/packages/forms/src/UIForm/fields/Date/Date.component.js
+++ b/packages/forms/src/UIForm/fields/Date/Date.component.js
@@ -55,6 +55,7 @@ function DateWidget(props) {
 			valueIsUpdating={valueIsUpdating}
 		>
 			<InputDatePicker
+				// eslint-disable-next-line jsx-a11y/no-autofocus
 				autoFocus={schema.autoFocus}
 				dateFormat={options.dateFormat}
 				disabled={schema.disabled || valueIsUpdating}
diff --git a/packages/forms/src/UIForm/fields/Date/DateTime.component.js b/packages/forms/src/UIForm/fields/Date/DateTime.component.js
index 12ce14fc54..22eac3e509 100644
--- a/packages/forms/src/UIForm/fields/Date/DateTime.component.js
+++ b/packages/forms/src/UIForm/fields/Date/DateTime.component.js
@@ -53,6 +53,7 @@ export default function DateTimeWidget(props) {
 		>
 			<InputDateTimePicker
 				id={id}
+				// eslint-disable-next-line jsx-a11y/no-autofocus
 				autoFocus={schema.autoFocus}
 				disabled={schema.disabled || valueIsUpdating}
 				readOnly={schema.readOnly}
diff --git a/packages/forms/src/UIForm/fields/Date/Time.component.js b/packages/forms/src/UIForm/fields/Date/Time.component.js
index 1a88b8dd20..57552c6e07 100644
--- a/packages/forms/src/UIForm/fields/Date/Time.component.js
+++ b/packages/forms/src/UIForm/fields/Date/Time.component.js
@@ -52,6 +52,7 @@ function TimeWidget({
 		>
 			<InputTimePicker
 				id={id}
+				// eslint-disable-next-line jsx-a11y/no-autofocus
 				autoFocus={schema.autoFocus}
 				disabled={schema.disabled || valueIsUpdating}
 				readOnly={schema.readOnly}
diff --git a/packages/forms/src/UIForm/fields/MultiSelectTag/MultiSelectTag.component.js b/packages/forms/src/UIForm/fields/MultiSelectTag/MultiSelectTag.component.js
index ab489e681f..fd18b75788 100644
--- a/packages/forms/src/UIForm/fields/MultiSelectTag/MultiSelectTag.component.js
+++ b/packages/forms/src/UIForm/fields/MultiSelectTag/MultiSelectTag.component.js
@@ -254,6 +254,7 @@ export default class MultiSelectTag extends Component {
 					<FocusManager onFocusOut={this.resetSuggestions} className={theme['focus-manager']}>
 						<Typeahead
 							id={id}
+							// eslint-disable-next-line jsx-a11y/no-autofocus
 							autoFocus={schema.autoFocus || false}
 							disabled={schema.disabled || valueIsUpdating}
 							focusedItemIndex={this.state.focusedItemIndex}
diff --git a/packages/forms/src/UIForm/fields/ResourcePicker/ResourcePicker.component.test.js b/packages/forms/src/UIForm/fields/ResourcePicker/ResourcePicker.component.test.js
index b65acf40b7..bf957c3ce6 100644
--- a/packages/forms/src/UIForm/fields/ResourcePicker/ResourcePicker.component.test.js
+++ b/packages/forms/src/UIForm/fields/ResourcePicker/ResourcePicker.component.test.js
@@ -5,66 +5,56 @@ import userEvent from '@testing-library/user-event';
 
 import ResourcePicker from './ResourcePicker.component';
 
-jest.mock('ally.js');
-jest.unmock('@talend/design-system');
-jest.mock(
-	'@talend/react-components/lib/ResourcePicker',
+const ResourcePickerMock =
 	() =>
-		({ toolbar, onRowClick, isSelected, collection, ...props }) =>
-			(
-				<div data-testid="ResourcePicker" data-props={JSON.stringify(props, null, 2)}>
-					<div data-testid="toolbar" data-props={JSON.stringify(toolbar, null, 2)}>
-						<div>
-							<label htmlFor="toolbar-name">{toolbar.name.label}</label>
-							<input
-								id="toolbar-name"
-								type="text"
-								onChange={e => toolbar.name.onChange(e)}
-								value={toolbar.name.value}
-							/>
-						</div>
-						<div className="tc-resource-picker-state-filters">
-							<button onClick={() => toolbar.state.onChange('selection', true)}>
-								state filter
-							</button>
-							<button onClick={() => toolbar.state.onChange('certified', true)}>
-								certified filter
-							</button>
-							<button onClick={() => toolbar.state.onChange('favorites', true)}>
-								favorites filter
-							</button>
-						</div>
-						<div className="tc-resource-picker-sort-options">
-							<button onClick={() => toolbar.sort.onChange('name', 'asc')}>sort by name</button>
-							<button onClick={() => toolbar.sort.onChange('date', 'asc')}>sort by date</button>
-
-							<button onClick={() => toolbar.sort.onChange('name', 'desc')}>
-								sort by name desc
-							</button>
-							<button onClick={() => toolbar.sort.onChange('date', 'desc')}>
-								sort by date desc
-							</button>
-						</div>
-					</div>
-					<button type="button" onClick={e => onRowClick(e, { id: '0' })}>
-						onRowClick
-					</button>
-					<button type="button" onClick={e => onRowClick(e, { id: '1' })}>
-						onRowClick first
+	({ toolbar, onRowClick, isSelected, collection, ...props }) => (
+		<div data-testid="ResourcePicker" data-props={JSON.stringify(props, null, 2)}>
+			<div data-testid="toolbar" data-props={JSON.stringify(toolbar, null, 2)}>
+				<div>
+					<label htmlFor="toolbar-name">{toolbar.name.label}</label>
+					<input
+						id="toolbar-name"
+						type="text"
+						onChange={e => toolbar.name.onChange(e)}
+						value={toolbar.name.value}
+					/>
+				</div>
+				<div className="tc-resource-picker-state-filters">
+					<button onClick={() => toolbar.state.onChange('selection', true)}>state filter</button>
+					<button onClick={() => toolbar.state.onChange('certified', true)}>
+						certified filter
 					</button>
-					<button type="button" onClick={e => isSelected(e)}>
-						isSelected
+					<button onClick={() => toolbar.state.onChange('favorites', true)}>
+						favorites filter
 					</button>
-					{collection && (
-						<span
-							data-testid="collection"
-							data-collection={JSON.stringify(collection, null, 2)}
-						></span>
-					)}
-					ResourcePicker
 				</div>
-			),
-);
+				<div className="tc-resource-picker-sort-options">
+					<button onClick={() => toolbar.sort.onChange('name', 'asc')}>sort by name</button>
+					<button onClick={() => toolbar.sort.onChange('date', 'asc')}>sort by date</button>
+
+					<button onClick={() => toolbar.sort.onChange('name', 'desc')}>sort by name desc</button>
+					<button onClick={() => toolbar.sort.onChange('date', 'desc')}>sort by date desc</button>
+				</div>
+			</div>
+			<button type="button" onClick={e => onRowClick(e, { id: '0' })}>
+				onRowClick
+			</button>
+			<button type="button" onClick={e => onRowClick(e, { id: '1' })}>
+				onRowClick first
+			</button>
+			<button type="button" onClick={e => isSelected(e)}>
+				isSelected
+			</button>
+			{collection && (
+				<span data-testid="collection" data-collection={JSON.stringify(collection, null, 2)}></span>
+			)}
+			ResourcePicker
+		</div>
+	);
+
+jest.mock('ally.js');
+jest.unmock('@talend/design-system');
+jest.mock('@talend/react-components/lib/ResourcePicker', ResourcePickerMock);
 
 describe('ResourcePicker field', () => {
 	const collection = [
diff --git a/packages/forms/src/UIForm/fields/Toggle/Toggle.component.js b/packages/forms/src/UIForm/fields/Toggle/Toggle.component.js
index 61e9e57683..515167bbc9 100644
--- a/packages/forms/src/UIForm/fields/Toggle/Toggle.component.js
+++ b/packages/forms/src/UIForm/fields/Toggle/Toggle.component.js
@@ -21,6 +21,7 @@ function ToggleWidget(props) {
 			valueIsUpdating={valueIsUpdating}
 		>
 			<Toggle
+				// eslint-disable-next-line jsx-a11y/no-autofocus
 				autoFocus={autoFocus}
 				checked={value}
 				disabled={disabled || valueIsUpdating}
diff --git a/packages/forms/src/UIForm/utils/properties.js b/packages/forms/src/UIForm/utils/properties.js
index 0f1d1b67e6..2346fdadfb 100644
--- a/packages/forms/src/UIForm/utils/properties.js
+++ b/packages/forms/src/UIForm/utils/properties.js
@@ -34,6 +34,7 @@ export function convertValue(type, value) {
  * @param {any} value The value to set
  * @returns {object} The new mutated properties.
  */
+// eslint-disable-next-line @typescript-eslint/default-param-last
 function mutateValueFromKey(properties = {}, key, value) {
 	if (!key || !key.length) {
 		return value;