-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRACKING] Breaking Changes Made During the RC Phase #1044
Comments
I was recently asked on our Discord:
I thought this was a great question and wanted to answer it in a more public-facing way as well. Transparently, I'm trying to get as many potentially breaking changes (even tiny ones) out the door as quickly as I can while retaining the quality of our software. Here's one such (big) example: Once this PR is merged (this/next week), we really only have two things to do:
Then we're v1. In regards to stability, our announcement to the RC phase was a commitment to as much stability as we could forsee. We had two breaking changes per: And #1104 might require some minimal refactor to fix some typing issues, but no runtime behavior will break (backed by our extensive test suite). I think the risk of using TanStack Form in production today is minimal and I'm already aware of some moderately high-profile usage of our product in prod today. That said, here's my thoughts on where we stand today compared to RHF. Even today, prior to v1 we're:
I think this puts us well above RHF in pragmatic terms today. |
Well y'all, I hate to say it, but we'll have a few breaking changes during our RC "stable" phase.
We just released our first two breaking changes in
0.38.0
:And, unfortunately, it's not the only two breaking changes we'll be making. In addition, we need to introduce two breaking changes to our React adapters:
form.useField
API, as it does not follow the rules of React Hooksform.useStore
API, as it does not follow the rules of React HooksWhich will be merged here shortly as part of
0.39.0
: #1035While these breaking changes are unfortunate, there were a few factors at play:
Derived
API would be fast enough to validate in TanStack Form for some time. I was wrong.2b) Once I realized we could use TanStack Store, working on it made it clear that there were bugs in the Angular adapter and TypeScript types that we needed to ship downstream
I wish I could have foreseen these issues ahead of time, but alas I am only human. Needless to say, once we hit v1, we'll be much more careful to introduce these breaking changes in chunks (ala major versions) and with migration guides to avoid problems.
Moreover, to help make this second batch of React breaking changes a little easier, we'll help write migration guides for
form.useField
andform.useStore
in our changelog for everyone impacted.Again, immense apologies on my end. I was the one who made the call to introduce these breaking changes prior to v1. We'll work hard on avoiding doing so again in the immediate future.
The text was updated successfully, but these errors were encountered: