Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about Svelte 5? #6674

Closed
frederikhors opened this issue Jan 10, 2024 · 6 comments
Closed

What about Svelte 5? #6674

frederikhors opened this issue Jan 10, 2024 · 6 comments

Comments

@frederikhors
Copy link
Contributor

frederikhors commented Jan 10, 2024

After opening #6673 I thought it was time to consider the imminent arrival of Svelte 5.

All news are beautiful explained here: https://svelte-5-preview.vercel.app/docs/introduction.

How do we plan to do it?

I think we can finally close bug like:

@lachlancollins
Copy link
Member

Everything in Query v5 should continue to work, since Svelte 5 is fully backwards compatible. A future Query version (v6?) will migrate from stores to runes.

@niemyjski
Copy link

niemyjski commented Jun 14, 2024

@lachlancollins is there an issue tracking the runes migration. It's been a huge pain working with derived queries with runes. Like a massive pain. It would be great to start a discussion on this. I feel like this issue works for that.

@lachlancollins
Copy link
Member

@lachlancollins is there an issue tracking the runes migration. It's been a huge pain working with derived queries with runes. Like a massive pain. It would be great to start a discussion on this. I feel like this issue works for that.

Hi @niemyjski, see this PR: #6981

@niemyjski
Copy link

@lachlancollins I replied here wondering if it's the correct approach and what was left. #6981 (comment)

@lachlancollins
Copy link
Member

Hi @frederikhors , I've merged #6981 into https://github.com/TanStack/query/tree/svelte-5-adapter

It's still not ready for release, but I would appreciate more people giving it a try and contributing!

@lachlancollins
Copy link
Member

We should probably continue discussion here: #7413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants