Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-query): eslint-plugin-query now working with vanilla js #8322

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(react-query): eslint-plugin-query now working with vanilla js #8322

wants to merge 4 commits into from
+1 −1

Conversation

ShyneADL
Copy link

To fix the issue with detecting imports in both TypeScript and JavaScript files, I modify the ImportDeclaration handler to handle cases where importKind might be undefined.

The key change is adding node.importKind === undefined to the condition. This ensures the import detection works for both TypeScript (where importKind is explicitly 'value') and JavaScript (where importKind is undefined).

This modification should resolve the lint plugin's compatibility issue with vanilla JavaScript apps by allowing import detection regardless of the importKind value.

closes #8257

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 22, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0a4e9fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 22, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8322

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8322

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8322

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8322

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8322

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8322

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8322

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8322

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8322

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8322

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8322

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8322

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8322

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8322

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8322

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8322

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8322

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8322

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8322

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8322

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8322

commit: 0a4e9fd

@TkDodo
Copy link
Collaborator

TkDodo commented Nov 22, 2024

there’s a lint error because typescript thinks the check is unnecessary:

/home/workflows/workspace/packages/eslint-plugin-query/src/utils/detect-react-query-imports.ts
  58:43  error  Unnecessary conditional, both sides of the expression are literal values  @typescript-eslint/no-unnecessary-condition

you must likely disable the linter for this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
package: eslint-plugin-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eslint-plugin-query not working with vanilla JS
2 participants
@ShyneADL @TkDodo