Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The QuickFilter plugin does not update its bounds when adding new data #535

Open
BenoitZugmeyer opened this issue Jun 25, 2018 · 1 comment
Labels

Comments

@BenoitZugmeyer
Copy link

I have some charts with live data rendered, and I want to use the QuickFilter plugin. But if the data we receive does not fit in the QuickFilter bounds, it will not be displayed. If all points are outside the bounds of the previous data, the serie is completely removed.

Example: https://jsfiddle.net/eqwfushL/13/

Expected: when the data changes, the plugin should update by adjusting the current bounds/limit and redraw itself.

@Mavrin Mavrin added the bug label Jun 27, 2018
@Mavrin Mavrin added the plugins label Aug 15, 2018
Mavrin added a commit that referenced this issue Aug 15, 2018
…s_settings

#535 implement field bounds for quick filter
@Mavrin
Copy link
Contributor

Mavrin commented Aug 15, 2018

Hi @BenoitZugmeyer
I'm not sure it's a good idea.
For example, User apply filter for cpu between 10 and 20, the original data set was [5, 10, 30, 50]. We apply new data set [30, 50, 100]. How should be filter changed? I don't know.
BTW I added new option for quick filter plugin. After release 2.4.0 you can specified bounds for field.
https://jsfiddle.net/eqwfushL/17/

QuickFilter({
  fields: ['cpu'],
  fieldBound: {
    cpu: {
      min: 0,
      max: 100
    }
  }
})

@Mavrin Mavrin removed the bug label Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants