Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactore Tests for AbstractTaskanaJob#initializingSchedule #2238

Open
arolfes opened this issue May 2, 2023 · 1 comment
Open

Refactore Tests for AbstractTaskanaJob#initializingSchedule #2238

arolfes opened this issue May 2, 2023 · 1 comment
Labels
enhancement

Comments

@arolfes
Copy link
Contributor

arolfes commented May 2, 2023

These 3 tests do exactly the same thing. During the refactoring, the logic was moved to AbstractTaskanaJob, but the tests were not adapted. Please do so here.

  • HistoryCleanupJobAccTest#should_DeleteOldHistoryCleanupJobs_When_InitializingSchedule()
  • TaskCleanupJobAccTest#should_DeleteOldTaskCleanupJobs_When_InitializingSchedule
  • WorkbasketCleanupJobAccTest#should_DeleteOldWorkbasketCleanupJobs_When_InitializingSchedule
@mustaphazorgati
Copy link
Member

In #2239 some further tests have been moved to AbstractTaskanaJobAccTest. Please refactor them before moving/refactoring the tests into that class. Thanks!

@jamesrdi jamesrdi mentioned this issue Dec 22, 2023
Closed
This was referenced Jan 2, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
TASKANA Kanban Board
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arolfes @mustaphazorgati