Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style popup does not work #25

Closed
asfonikos opened this issue Apr 20, 2023 · 10 comments
Closed

style popup does not work #25

asfonikos opened this issue Apr 20, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@asfonikos
Copy link

asfonikos commented Apr 20, 2023

Hello,
I have a problem with pdf button in an article, popup is blank. My Joomla version is 4.2.9.
Thank you.

pdf_viewer_error

@Tazzios
Copy link
Owner

Tazzios commented Apr 20, 2023

That is not much information to go on. What is the exact tag that you are using? Does embed or new works?

@Tazzios Tazzios added the bug Something isn't working label Apr 20, 2023
@Tazzios
Copy link
Owner

Tazzios commented Apr 20, 2023

Ok, did some testing: it seems the Joomla 4 modal popup works different then in Joomla3. The modal popup is not working since the beginning.
So I will note it as a bug and look in to it.

@asfonikos
Copy link
Author

First of all congratulations for your great job. This plugin is very good and works perfect in Joomla3. I just wanted to let you know what I found out in joomla4. If you write the link code inside article editor works fine. Just the modal popup is not working for me.
Thank you for your answers.

@Tazzios Tazzios changed the title PDF Button style popup does not work Apr 23, 2023
Tazzios added a commit that referenced this issue Apr 23, 2023
Fix for #25 and #26 . But breaks the popup in joomla 3. Find out if there is something universal or that i have to do a version check.
@asfonikos
Copy link
Author

I tested but PDF Button in an article is not working, οpen a blank popup.

@Tazzios
Copy link
Owner

Tazzios commented Apr 28, 2023

Did you copied it from the correct branch and to the right location?
Anyway, here is a build that (should) work for j3 and j4
https://github.com/Tazzios/pdfviewer/releases/tag/v1.3.1

@Tazzios
Copy link
Owner

Tazzios commented May 5, 2023

@asfonikos does v1.3.1 (now also as autoupdate) works for you? Then i could close this issue.

@marpyth
Copy link

marpyth commented May 7, 2023

Same problem here: when clicking the PDF button in the article editor, the pop up is completely empty.
In V 1.3.1 package there is no editor button asset by the way, so you first have to install 1.3.0, and then update the pdf content plugin to 1.3.1. Button version remains 1.3.0
The pdf viewer generally works perfect in the website. Thansk!

@Tazzios
Copy link
Owner

Tazzios commented May 7, 2023

content pdfviewer popup works in J4

@Tazzios Tazzios closed this as completed May 7, 2023
@Tazzios
Copy link
Owner

Tazzios commented May 7, 2023

ah, I missed that this was also about the Button instead of the content plugin.

@asfonikos
Copy link
Author

I have the same problem with @marpyth. Otherwise the pdf viewer works fine. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants