[Feature/#291] storedetail qa #296
Conversation
WalkthroughThis pull request applies visual refinements to the store detail module. The changes update several UI components and resource files: an icon resource update in the detail route, layout modifications to button and header composables, and color adjustments for price text. Additionally, vector drawable assets have been added and revised, and a caution message string has been updated. No functional logic or public entity declarations have been altered. Changes
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? ๐ชง TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
๐งน Nitpick comments (1)
feature/storedetail/src/main/res/values/strings.xml (1)
9-9:โ Verification inconclusive
Consider adding localized versions of the caution message.
Since this is a user-facing string in the default values folder, consider adding translations for international users if your app supports multiple languages.
Let's check if there are any localized string resources:
๐ Script executed:
#!/bin/bash # Description: Check for localized versions of strings.xml # Look for values-* directories that might contain localized strings fd -t d "values-[a-z][a-z]" "feature/storedetail/src/main/res"Length of output: 62
Localized Caution Message โ Please Verify Internationalization
After our search, thereโs no evidence of additional localized string resource directories (e.g.,
values-en,values-es, etc.) infeature/storedetail/src/main/res. Since the caution message is user-facing, if your app supports multiple languages you should add corresponding translations. Please verify if additional locale-specific folders are expected or needed for international users and add them accordingly.
๐ Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
๐ Files selected for processing (9)
feature/storedetail/src/main/java/com/hankki/feature/storedetail/StoreDetailRoute.kt(1 hunks)feature/storedetail/src/main/java/com/hankki/feature/storedetail/component/StoreDetailButton.kt(1 hunks)feature/storedetail/src/main/java/com/hankki/feature/storedetail/component/StoreDetailHeadBox.kt(1 hunks)feature/storedetail/src/main/java/com/hankki/feature/storedetail/component/StoreDetailItem.kt(2 hunks)feature/storedetail/src/main/java/com/hankki/feature/storedetail/component/StoreDetailMapBox.kt(1 hunks)feature/storedetail/src/main/java/com/hankki/feature/storedetail/component/StoreDetailMenuBox.kt(3 hunks)feature/storedetail/src/main/res/drawable/ic_arrow_under.xml(1 hunks)feature/storedetail/src/main/res/drawable/ic_bottom_edit.xml(1 hunks)feature/storedetail/src/main/res/values/strings.xml(1 hunks)
โ Files skipped from review due to trivial changes (3)
- feature/storedetail/src/main/java/com/hankki/feature/storedetail/component/StoreDetailItem.kt
- feature/storedetail/src/main/res/drawable/ic_arrow_under.xml
- feature/storedetail/src/main/java/com/hankki/feature/storedetail/StoreDetailRoute.kt
๐ Additional comments (8)
feature/storedetail/src/main/res/drawable/ic_bottom_edit.xml (2)
1-5: LGTM! Well-structured vector drawable definition.The vector drawable is properly defined with:
- Dimensions in dp units for consistent scaling
- Matching viewport dimensions
6-14: LGTM! Clean and semantic path structure.The vector paths create a clear visual hierarchy:
- Light gray background with rounded corners
- Medium gray edit pencil icon with proper contrast
feature/storedetail/src/main/java/com/hankki/feature/storedetail/component/StoreDetailHeadBox.kt (1)
44-44: LGTM! Consistent spacing applied.The added top padding of 18.dp aligns well with other vertical spacing in the component (matches line 94).
feature/storedetail/src/main/java/com/hankki/feature/storedetail/component/StoreDetailMenuBox.kt (2)
36-36: LGTM! Improved vertical spacing.The reduced padding creates a more compact layout while maintaining readability.
84-84: LGTM! Better icon color handling.Using Color.Unspecified allows the icon to maintain its original colors, which is appropriate for custom icons.
feature/storedetail/src/main/java/com/hankki/feature/storedetail/component/StoreDetailButton.kt (1)
138-148: LGTM! Improved button layout structure.The changes enhance the button's layout by:
- Centering content appropriately
- Removing unnecessary nesting
- Maintaining consistent vertical padding
feature/storedetail/src/main/java/com/hankki/feature/storedetail/component/StoreDetailMapBox.kt (1)
136-142: LGTM! Enhanced address row layout.The changes improve the address section's appearance through:
- Better balanced padding values
- Cleaner code formatting for vertical alignment
feature/storedetail/src/main/res/values/strings.xml (1)
9-9: Great improvement in the caution message wording!The change from "personal feelings" to "reported content" makes the warning more objective and professional, better reflecting the nature of user-reported information.
There was a problem hiding this comment.
๊ณ ์ํ์ด์! ์ต๊ณ ~~~~
๊ทธ๋ฐ๋ฐ ํ๋๋ง ๋ ํ์ธํด์ฃผ์ธ์! ์์ ์ ๋ฐ๊ฒฌํ๋ ๋ฒ๊ทธ์ธ๋ฐ ์ฃผ์๊ฐ ๊ธธ์ด์ง๋ฉด ๋ณต์ฌ๋ฒํผ์ด ์ฌ๋ผ์ง ์ด๊ฒ์ ๊ด๋ จ๋ QA ์ฌํญ์ ์๋๊ฒ ๊ฐ์์ ํ๋ฒ๋ง ์ฒดํฌ๋ถํ๋๋ ค์ :)
์์ ์๋๋ค๋ฉด ์์ ๋ถํ๋๋ฆฌ๊ณ , ์์ ์ด ๋๋ค๋ฉด.... ์ฃ์กํฉ๋๋ค ํํ ๐๐ปโโ๏ธ
There was a problem hiding this comment.
nit. ๋ญ๊ฐ... under๊ฐ ์ด์ํ ๋๋...?
Meterail์์ ์ ํด๋ ์ด๋ฆ์ฒ๋ผ ic_arrow_down ์ด๋ค๊น์ฉ~?
There was a problem hiding this comment.
์ ์ ๋ชป๋ฐ๊ฒฌํ๋ ํผ๊ทธ๋ง๋ ๋ค๋ฅธ ๋ถ๋ถ์ด ๋ณด์ฌ์ ์ฝ๋ฉํธ๋จ๊ฒจ์ฉ..! ๊ธฐ๋ฅ ๋ด๋น์๋ผ๋ฆฌ ์ด์ผ๊ธฐํด์ ๋ฐ๋ ๊ฑธ์๋ ์์ผ๋ ํ ๋ฒ ํ์ธํด์ฃผ์๋ฉด ๊ฐ์ฌํ๊ฒ ์ต๋๋ค :)
- ํ๋จ ๋ฒํผ ํ ์คํธ ์คํ์ผ์ด ์ ์ฉ๋์ง ์์ ๊ฒ ๊ฐ์์ !
| ํผ๊ทธ๋ง ๋ฒ์ | ํ์ฌ๋ฒ์ |
|---|---|
 |
 |
- ํผ๊ทธ๋ง์๋ ๋ชจ๋ฌ ๋ฒํผ ํ์ธ์ด๋ผ๊ณ ๋์ด์์ด์..!
๐ Issue
โณ๏ธ Work Description
๐ธ Screenshot
๐ข To Reviewers
Summary by CodeRabbit
Style
Documentation