-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should I make pull requests for my CMake branches? #36
Comments
Hello. Maybe it would be convenient you to make a pull request that adds a CMakefile into tool_name/src/cmakefile/. Makefiles are in my opinion good to keep build working, without caring about CMake versions that could break compilation. You seem to use CMake because android aarch64 does not support Makefiles? |
Yeah. I use CMake because the setup and compilation on Termux is a lot easier. It adds all the flags needed for the platform and only needs minor modifications to get stuff working sometimes. |
I'm not sure if moving the CMakeLists.txt into a directory without the source code will work, I'll need to look into that. Though, CMake shouldn't overwrite the original Makefile since you have to build out of source or the tool will complain and fail before generating the build-script. |
It looks like it's not widely recommended to place CMakeLists.txt into a subdirectory. Especially since it could cause some issues on more complex nested projects. |
Or just keep them on my own fork? Do you prefer for the project to stay only with Makefiles?
The text was updated successfully, but these errors were encountered: