Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should I make pull requests for my CMake branches? #36

Open
JeffreyO opened this issue Jul 30, 2023 · 4 comments
Open

Should I make pull requests for my CMake branches? #36

JeffreyO opened this issue Jul 30, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@JeffreyO
Copy link

JeffreyO commented Jul 30, 2023

Or just keep them on my own fork? Do you prefer for the project to stay only with Makefiles?

@CelesteBlue-dev
Copy link
Contributor

Hello. Maybe it would be convenient you to make a pull request that adds a CMakefile into tool_name/src/cmakefile/.

Makefiles are in my opinion good to keep build working, without caring about CMake versions that could break compilation. You seem to use CMake because android aarch64 does not support Makefiles?

@CelesteBlue-dev CelesteBlue-dev added the enhancement New feature or request label Aug 9, 2023
@JeffreyO
Copy link
Author

JeffreyO commented Aug 9, 2023

Yeah. I use CMake because the setup and compilation on Termux is a lot easier. It adds all the flags needed for the platform and only needs minor modifications to get stuff working sometimes.

@JeffreyO JeffreyO closed this as completed Aug 9, 2023
@JeffreyO
Copy link
Author

JeffreyO commented Aug 9, 2023

I'm not sure if moving the CMakeLists.txt into a directory without the source code will work, I'll need to look into that.

Though, CMake shouldn't overwrite the original Makefile since you have to build out of source or the tool will complain and fail before generating the build-script.

@JeffreyO JeffreyO reopened this Jul 26, 2024
@JeffreyO
Copy link
Author

It looks like it's not widely recommended to place CMakeLists.txt into a subdirectory. Especially since it could cause some issues on more complex nested projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant