Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on search #102

Open
deadspidervenom opened this issue Dec 9, 2024 · 7 comments
Open

Errors on search #102

deadspidervenom opened this issue Dec 9, 2024 · 7 comments

Comments

@deadspidervenom
Copy link

Steps to reproduce

  1. Be on my server or a darkrp server using my addons (https://steamcommunity.com/sharedfiles/filedetails/?id=3373536803)
  2. go to prop menu
  3. Search for a prop

Expected behavior

Tell us what should happen

For the prop to be found

Actual behavior

Tell us what happens instead

Nothing searched and errors get spammed endlessly in player console

Error(s) in server console, if any

None

Error(s) in player's console, if any

[ulib-master] lua/includes/modules/notification.lua:51: attempt to call method 'SetProgress' (a nil value)

  1. AddProgress - lua/includes/modules/notification.lua:51
  2. GetAllFiles - gamemodes/sandbox/gamemode/cl_search_models.lua:33
    3. fn - gamemodes/sandbox/gamemode/cl_search_models.lua:43
    4. unknown - addons/ulib-master/lua/ulib/shared/hook.lua:109 (x3357)

Warning: Unhandled usermessage '_Notify'

Version

Run "ulx version" in console and paste the result

ULib v2.71d (04/05/24)
ULX v3.81d (07/19/24)

@JamminR
Copy link

JamminR commented Dec 9, 2024

This is 99% certainty not a Ulib error but a conflict with one of your many addons.
You can prove this yourself by temporarily removing ULib and ULX.
The only reason ULib is mentioned is due to the fact we overwrite and add priority improvement to the default GMod hook call.

Additionally, the 'SetProgress' command/function does not exist in ULib.

@deadspidervenom
Copy link
Author

This error was not occurring when i used the workshop variant of these addons. I can try and see if i can figure out the conflict as other mods have spit out the same error for different reasons.

Granted around the time i swapped from the workshop version to the github i also swapped from gmods normal client to the x64 variant.

Also for my addons, most have been previously tested with both ulx and ulib with no errors, or have direct compatibility with it. As to why i came here.

@deadspidervenom
Copy link
Author

based on what i can figure out on the error code it is a conflict with this part

"4. unknown - addons/ulib-master/lua/ulib/shared/hook.lua:109"

As the rest is not from ulib.

What does this part deal with? to make it easier to locate the conflict.

@ApertureDevelopment
Copy link

ApertureDevelopment commented Dec 9, 2024

The reason this error is happening because you ( or whatever addon adds this file lua/includes/modules/notification.lua ) is calling a non existent method. The only reason ulib is mentioned within the error trace is because ulib replaces the default hook library, but it is not the cause of the error.

You can also look into the GMod wiki to see that the method SetProgress also does not come from GMod, so it must be a conflicting/missing addon https://wiki.facepunch.com/gmod/~search?q=SetProgress

After checking the file in question inside Facepunches GitHub repository, it looks like the method is added in the same file. So the reason it says its a nil value means that either the file is incomplete/broken or that something is overwriting the panel object
https://github.com/Facepunch/garrysmod/blob/master/garrysmod/lua/includes/modules/notification.lua#L269

@JamminR
Copy link

JamminR commented Dec 10, 2024

I doubt Gmod's code is root cause.
I know with 99% certainty that Ulib is not the 'fault'.
@deadspidervenom - As ApertureDevelopment commented before striking his original out - Ulib is only mentioned because we overwrite Gmod's original hook library. So instead of the error saying Gmod's \lua\includes\modules\hook.lua, it mentions our hook.lua path.
Some code of all your addons, "SetProgress" and "_Notify" are the two items failing within your error code.

@deadspidervenom
Copy link
Author

deadspidervenom commented Dec 10, 2024

I doubt Gmod's code is root cause. I know with 99% certainty that Ulib is not the 'fault'. @deadspidervenom - As ApertureDevelopment commented before striking his original out - Ulib is only mentioned because we overwrite Gmod's original hook library. So instead of the error saying Gmod's \lua\includes\modules\hook.lua, it mentions our hook.lua path. Some code of all your addons, "SetProgress" and "_Notify" are the two items failing within your error code.

Regardless of who is at fault, it erroring under ulib. Which mean its ulibs fault until proven otherwise. If you dont like that, than perhaps make it so ulib points at who is actually at fault.

Stop being a broken record and being unhelpful and unproductive, i asked a serious question since i have legit no idea which addon could be the cause and i am not going through over a 100 addon workshop files due to the numerous workship files downloaded by the server testing various addons, extracting each and every one, manually checking for the file since windows search is a pos.

On top of that, instead of possibly getting bug reports like these over and over, telling them "its not our fault" and having them be forced to do what i mentioned, likely getting tired and just removing ulib and ulx. You could be helping them, and making a list a mods that are the issue, so you can properly blame other addons with 100% certainty instead of 99%, because you never know if this could be the 1% and you being so insistent on it not being so making it so it never gets fixed.


The reason this error is happening because you ( or whatever addon adds this file lua/includes/modules/notification.lua ) is calling a non existent method. The only reason ulib is mentioned within the error trace is because ulib replaces the default hook library, but it is not the cause of the error.

You can also look into the GMod wiki to see that the method SetProgress also does not come from GMod, so it must be a conflicting/missing addon https://wiki.facepunch.com/gmod/~search?q=SetProgress

After checking the file in question inside Facepunches GitHub repository, it looks like the method is added in the same file. So the reason it says its a nil value means that either the file is incomplete/broken or that something is overwriting the panel object https://github.com/Facepunch/garrysmod/blob/master/garrysmod/lua/includes/modules/notification.lua#L269

Thanks for the help, this means newer addons are less likely the cause and i should look at older addons.

@JamminR
Copy link

JamminR commented Dec 11, 2024

It is not erroring under Ulib. I'm not the only one here telling you that.
Root is mentionedy within the first 2-3 lines of a trace.
Not sure how the commenters replying to you can help you understand that.
"SetProgress" and "_Notify" are the two items failing within your error, and ULib doesn't use either of those as commands or variable names.
The quickest way to prove with 100% certainty that it wasn't ULib was, for a short time, test by removing ULib and ULX from the server.
I imagine errors would still occur, and likely include Gmod's hook instead of ours as the final line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants