-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Fix registrations created with postalcode1 = NULL #127
Comments
Might be related with: |
We have a single endpoint for updating user information which is used for several things (sending postal code, sending opt-in flags, so on). If we make the postal code mandatory at this endpoint we might end up breaking the UI. Therefore, my suggestion is to update the user's postal code when a new case is received, since the postal code is mandatory for the case endpoint. |
We can do that. Don't call it "case" though to avoid confusion. We calling it "status update". We also need to remove the property "Cases" being returned from /api/v1/user |
During registration, after logging with Facebook, the user lands in the account settings page. Immediately, a row is inserted in the database with postalcode1 and postalcode2 = null. So, it seems that in these cases the user never successfully submits this form. Multiple reasons occur to me:
We should absolutely investigate if we have UX problems in this form, but we also consider only doing a first PUT after this screen, not before. Why are we doing a PUT with NULL values to postalcodeX ? |
|
I'm moving this back to TODO as we need to see what happens when we deploy this fix: In the meantime, I've created this issue to avoid creating these records with all null fields: |
Some registrations are created with postalcode1=NULL.
27 March we had 12.2% of all registrations having postalcode1 = NULL
This is an urgent bug that must be fixed ASAP.
First prevent the API from accepting NULL postalcode1 returning an error. Then investigate what leads to that situation in the first place.
The text was updated successfully, but these errors were encountered: