Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Middle Name in no-overwrite function #4

Open
magnolia61 opened this issue Aug 4, 2014 · 2 comments
Open

Include Middle Name in no-overwrite function #4

magnolia61 opened this issue Aug 4, 2014 · 2 comments

Comments

@magnolia61
Copy link
Contributor

Since we include Middle Name in out profiles, it would be very usefull for us to include the middle name field in this extension. I still need to figure out submitting PR's etcetera. Be gracefull on me. This is the code change I propose. Thanks a lot for your hard work. :-) Regards, RIchard

noverwrite.js

  • $.each(["#first_name","#last_name"],function (k,v) {
  • $.each(["#first_name","#middle_name","#last_name"],function (k,v) {

noverwrite.php

  • foreach (array( 'first_name', 'last_name') as $f) {
    +foreach (array( 'first_name', 'middle_name','last_name') as $f) {
@tttp
Copy link
Member

tttp commented Aug 5, 2014

Hi,
We don't use middle name and that's why I didn't think about including it, but this would be a welcome addition!

PR isn't that scary, you do a fork, do the change on your fork, push it and voila, it's ready for a PR ;)
github has a decent documentation on the topic.

I'm going to be moving between cities in the next two weeks but will check my email regularly.

@magnolia61
Copy link
Contributor Author

The disabling of the middle_name field (which 50% of dutch names use, 50% not) was not working when the value was empty. Found the line of code that caused it and set up this PR: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants