Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Widget reloads completed item as incomplete #1601

Closed
86ul opened this issue Oct 23, 2024 · 8 comments
Closed

[BUG] Widget reloads completed item as incomplete #1601

86ul opened this issue Oct 23, 2024 · 8 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@86ul
Copy link

86ul commented Oct 23, 2024

Describe the bug

On my FairPhone 3 with LineageOS 21, I experience with recurring tasks (weekly groceries, cleaning, garbage, etc) that after checking an item as complete, the widget refresh (normal), but adds the completed task back to the list as incomplete (abnormale).

When I check it off again as complete inside this widget, then JTX does not just that item in the series, but completes the full series as finished.

However, when I go straight to the app itself (either through the widget, or launcher), JTX behaves like expected: it only checks off the item as completed, without completing the full series.

To Reproduce

  1. Checking an item of a series as completed
  2. Noticing the widget refreshes
  3. Noticing the widgets reloads the completed item
  4. Checking this item again as completed
  5. Finding this item/series back as fully completed

Expected behavior

Checking only that specific item as completed, and refresh the list with neither this item, nor completed the series of that item

Screenshots

Device and version

  • Device: FairPhone 3
  • Android version: LOS21
  • jtx Board version: 2.09.01
  • Downloaded from: Fdroid
@86ul 86ul added the bug Something isn't working label Oct 23, 2024
@86ul 86ul changed the title [BUG] [BUG] Widget reloads completed item as incomplete Oct 23, 2024
@86ul
Copy link
Author

86ul commented Dec 26, 2024

Still happens with JTX 2.09.04.ose...

@86ul
Copy link
Author

86ul commented Jan 17, 2025

@patrickunterwegs is there fix for this issue, which seem not related to #1652

@patrickunterwegs
Copy link
Member

Hi @86ul , sorry for not coming back to this earlier.
I couldn't reproduce this issue, it's really strange what you describe.
When you open the series (meaning when you open one instance and then click on "Go to series", is that element checked?

@86ul
Copy link
Author

86ul commented Jan 21, 2025

@patrickunterwegs thanks for checking in on this issue. Because I am already used to use the workaround (opening app, and then completing a task with a series), I have to reproduce it myself too again. Just to verify that it is still relevant on LOS21 of 25th December of 2024 with jtx 2.09.04.ose...

Edit: although the series are no longer also checked as completed, I have to check the task as completed twice. With the first try, the widget refreshes. With the second try, only the task itself got checked as completed.

Edit after update: still present in jtx 2.10.00.ose

@patrickunterwegs
Copy link
Member

Thanks @86ul !
Can you try one more thing: When you check a task in the widget and it doesn't work, can you open the app and check if the given task is checked in the app?
I would like to know if the action was actually not done or if the widget was refreshed before the action of checking the task is stored in the database.

@86ul
Copy link
Author

86ul commented Jan 23, 2025

@patrickunterwegs just tried it: after completing a task in a series in the widget, the task is marked as completed and the widget refreshes. After refreshing, the task is no longer marked as completed, neither on the widget, nor in the app. In order to mark this task in a series, I have to mark this task in the app as completed.

@patrickunterwegs
Copy link
Member

Thanks @86ul , as it seems to work for most other users (and as I can't reproduce it), I can only try something. I have an idea and I'll make the change now.

@patrickunterwegs patrickunterwegs added this to the 2.10.1 milestone Jan 24, 2025
@patrickunterwegs
Copy link
Member

@86ul , I have made the change, it shouldn't affect other users, but there is a chance that this issue could be solved. It would be great if you could check once 2.10.1 is available. I'll prepare a beta probably today and release it maybe next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants