Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuse when user profile path includes an exclamation mark #271

Open
Pyker opened this issue Jun 16, 2022 · 1 comment
Open

Refuse when user profile path includes an exclamation mark #271

Pyker opened this issue Jun 16, 2022 · 1 comment
Labels

Comments

@Pyker
Copy link
Member

Pyker commented Jun 16, 2022

The launcher should display an error and immediately exit, if the user profile path includes an exclamation mark (!), since that causes issues with Java misinterpreting it as a path to a JAR and a path inside said JAR file.

This is always a problem even if the user installs the launcher to a different folder, since the launcher always checks %APPDATA%\.technic\settings.json so it can determine where it's installed. This should not be a problem in portable mode, since it checks the current folder and uses that directly, instead of checking appdata.

@Pyker Pyker added bug Priority: Low Low priority labels Jun 16, 2022
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale Inactive issue label Aug 26, 2023
@Pyker Pyker removed the stale Inactive issue label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant