Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are modversions ordered by number and not by date #538

Open
fcpwiz opened this issue Jan 9, 2016 · 4 comments
Open

Why are modversions ordered by number and not by date #538

fcpwiz opened this issue Jan 9, 2016 · 4 comments

Comments

@fcpwiz
Copy link

fcpwiz commented Jan 9, 2016

Since modversions are ordered by number the modversions are all out of order. For example, in a list ordered from oldest to newest modversions, 4.2.19 comes before 4.2.2 (because 1 is smaller than 2, but 19 isn't smaller than 2). It should be the other way around, that's why I think modversions should be ordered by date and not by number.

screen shot 2016-01-09 at 5 50 25 pm

Look, 1.2.12 is the latest version, though it's in the middle of the list. This makes it easy to make a dumb mistake when picking the correct modversion.
@spannerman79
Copy link

Dupe #492 - sort of

@fcpwiz
Copy link
Author

fcpwiz commented Jan 9, 2016

@spannerman79 Yeah I have that issue too. Really really annoying. Seems like an easy fix if all builds were dated and sorted by that and not by number.

@spannerman79
Copy link

Only issue is the weird way that some mod devs number their build versions. Not to mention sometimes a modder (or two) just re-uploads the same version number when clearly there has been changes made. CustomNPC is one such mod 😦

It would be "nice" if mod devs followed some sort of correct versioning system. Hell even at the end (if they use Travis/Jenkis/etc) they can stick their build numbers on the end themselves if they wish.

@heddendorp
Copy link
Contributor

This
https://github.com/TechnicPack/TechnicSolder/blob/master/app/views/modpack/build/view.blade.php#L85
should be changed to ->sortByDesc('updated_at', SORT_NATURAL).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants