Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download URL text is wrong when version is first added. #563

Open
adamk33n3r opened this issue Mar 7, 2016 · 8 comments
Open

Download URL text is wrong when version is first added. #563

adamk33n3r opened this issue Mar 7, 2016 · 8 comments

Comments

@adamk33n3r
Copy link

When I first add a version of a mod the Download URL text seems to be corrupt. The url of the link itself is correct because if I click on it it correctly downloads the mod. It's just the text as you can see in the image below.
image
If I refresh the issue goes away, though.
image

@spannerman79
Copy link

Strange - I just installed solder fresh on a new VPS and I don't have that issue.

I am using MySQL, PHP 5.6 and Apache though

@adamk33n3r
Copy link
Author

Hm. I'm using sqlite, php7, and nginx if that helps.

@spannerman79
Copy link

It could be a combination of PHP7 & ngix - maybe. I did notice with some of the commits in dev branch there was some work on PHP7 being done - not sure if its ready for PHP7 or not. Someone else will have to answer that.

@spannerman79
Copy link

Hang on, your right @adamk33n3r. It just happened to me as well.

So far it happens on

  • Apache or nginx
  • SQLite or MySQL
  • PHP7 or 5.6

For the record my VPS that I just installed to is CentOS 7.

My apologies for jumping the gun on you @adamk33n3r.

@adamk33n3r
Copy link
Author

@spannerman79 no worries :)

Mines installed on an arch box for the record.

@tankerkiller125
Copy link

I also have this issue.

  • Ubuntu 14.04 LTS Server
  • MySQL (Percona Cluster to be exact)
  • PHP 7.0
  • Nginx (Latest)

I also just tested it on an AWS VPS and saw the issue there as well.

@aschmois
Copy link
Contributor

There's an extra { in code, it's a very simple fix.

https://github.com/TechnicPack/TechnicSolder/blob/master/app/views/mod/view.blade.php#L149

Change the line from:
$("#add-row").after('<tr><td></td><td>' + data.version + '</td><td>' + data.md5 + '</td><td><a href="' + mirror_url + 'mods/{{ $mod->name }}/{{ $mod->name }}-' + data.version + '.zip" target="_blank">{mods/{{ $mod->name }}/{{ $mod->name }}-' + data.version + '.zip</a></td><td>' + data.filesize + '</td><td></td></tr>');

to:
$("#add-row").after('<tr><td></td><td>' + data.version + '</td><td>' + data.md5 + '</td><td><a href="' + mirror_url + 'mods/{{ $mod->name }}/{{ $mod->name }}-' + data.version + '.zip" target="_blank">' + mirror_url + 'mods/{{ $mod->name }}/{{ $mod->name }}-' + data.version + '.zip</a></td><td>' + data.filesize + '</td><td></td></tr>');

And the issue fixes itself.

aschmois added a commit to aschmois/TechnicSolder that referenced this issue Jun 27, 2016
GenPage pushed a commit that referenced this issue Sep 16, 2016
@GenPage
Copy link
Contributor

GenPage commented Sep 16, 2016

Will close issue once dev is merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants