The term 'Hide Modpack' is ambiguous/confusing/unhelpful

[skwerlman]

While debugging a recent issue (#588), I realized that the current name for the option that prevents a modpack from appearing in api responses is confusing, especially since the same term is used on the Platform to describe totally different functionality.

I propose we change it, though I am not sure what it should be called.

Maybe something like "Unlist Pack"?

[GenPage]

@skwerlman That is a very good point. I am okay with the change

[Indemnity83]

Maybe more of a concept for a rewrite; but wouldn't it be eaiser to just simplify the two checkboxes into a single drop down with three options; basically exactly like YouTube privacy settings work:

• Public: Can be seen by anybody on the Technicpack.net site, and the launcher and will show up in search results
• Unlisted: Won't show up on Technicpack.net site, the launcher or in search results, but anybody with the link can see them
• Private: Can only be seen by you and others your choose (Client access for the launcher)

If you just change "Hidden Modpack" on the platform settings page to "Unlisted" then these rules still generally apply; except that since the platform doesn't support Clients, there is no "private" mode.

[Indemnity83]

Working through this more; in solder it really could be simplified to a single field. a published status would replace both the hide modpack and private modpack options.

To any visitor, a published modpack would be visible and a modpack that isn't published wouldn't be visible. Which is the primary use case.

For known clients (providing a launcher client id, or other auth token) the unpublished modpacks would also be included in results.

If you don't want the modpack to show in API responses at all, then simply don't publish it, and do not grant any known clients access to the modpack.

The same logic could be applied to builds.

I think this would be easier to implement in code, and significantly less likely to break during refractors as the possible privacy combinations goes from 16 for a single modpack and build down to just a couple.

Modpack Published	Build Published	Guest or Unknown Client	Known Client
✅	✅	👁️ Modpack - 👁️ Build	👁️ Modpack - 👁️ Build
✅	⬜	👁️ Modpack - 🔒 Build	👁️ Modpack - 👁️ Build
⬜	✅	🔒 Modpack - 🔒 Build	👁️ Modpack - 👁️ Build
⬜	⬜	🔒 Modpack - 🔒 Build	👁️ Modpack - 👁️ Build