Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSIM and PSNR bit depths are fixed to 10 bit #6

Open
Ali-Flt opened this issue Jun 8, 2022 · 1 comment
Open

SSIM and PSNR bit depths are fixed to 10 bit #6

Ali-Flt opened this issue Jun 8, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Ali-Flt
Copy link

Ali-Flt commented Jun 8, 2022

In quat/visual/fullref.py the PSNR and SSIM calculation bitdepth argument is fixed to 10. I think this results in invalid psnr output for 8 bit videos because I saw PSNR values of around 100 when I think they should be around 30 to 50 righ?

Edit: I changed the bitdepth of psnr calculation to 8 and still the values are around 100, why is that?

@stg7
Copy link
Member

stg7 commented Jun 8, 2022

well, the reason why it is fixed to 10 bit is that the maximum bitdepth for the videos which have been used during development and evaluation was 10 bit, therefore this was to be assumed to be the maximum,
however, the iterate by frame methods use from skimage import img_as_uint as an aggregation and unification step, thus each frame will be automatically a 16 bit uint frame. (the skvideo.measure.psnr method seems to convert each frame anyhow later to a float32 for the calculation of psnr), this seems to be a bit mystical.

i will have a look on it.

@stg7 stg7 self-assigned this Jun 8, 2022
@stg7 stg7 added the enhancement New feature or request label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants