Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funnel Navigation Bar [D] Logo size Bug in Figma #2055

Closed
henriquebarrosr opened this issue Feb 6, 2025 · 3 comments
Closed

Funnel Navigation Bar [D] Logo size Bug in Figma #2055

henriquebarrosr opened this issue Feb 6, 2025 · 3 comments
Labels
bug 🐞 Something isn't working

Comments

@henriquebarrosr
Copy link

Describe the bug

The component in code is already correct, but in Figma when we change the logo it appears distorted, because the width is fixed.

Figma Link


Default Component
Image

Default Component with changed Logo component
Image

What libraries are you seeing the problem on?

Desktop Library

Steps to reproduce

  1. Select and the component Funnel Navigation Bar [D] to your canvas
  2. Select the component Logo inside the Funnel Navigation Bar [D]
  3. Select another logo from any other library
  4. See the result

Expected behavior

Ideally, the Logo element should be adjusted so that it does not have a fixed size, and can load the more horizontal versions without flattening them.

@henriquebarrosr henriquebarrosr added the bug 🐞 Something isn't working label Feb 6, 2025
@aweell
Copy link
Collaborator

aweell commented Feb 7, 2025

Hola @henriquebarrosr, envolviendo el logo en un autolayout debería solucionar el problema, la otra opción es que traiga autolayout la instancia de logo directamente, aunque consideraría mas segura la primera.

Por regla general recomendamos que las instancias que hacen swap se las envuelva en un frame con autolayout para evitar que como definimos que se comporte su padre pueda afectar al hijo que se reemplaza.

Aqui un ejemplo:

https://www.figma.com/design/MY4cZEgzX3Y274uDXNKwtc/Funnel-Navigation-Bar-%5BD%5D-(Copy)?node-id=1-3&p=f&t=gPbDaxH1DdR5B6jC-0

Si esto resuelve tu problema, comunícame por aquí para poder cerrar el ticket

@henriquebarrosr
Copy link
Author

Hello @aweell!
We made an adjustment in our Vivo Assets logo library by adding the auto-layout property on them, and now logos are loaded correctly.
Thank you for your help and support!

@aweell
Copy link
Collaborator

aweell commented Feb 17, 2025

Great! Thank you for opening an issue 🤟🏼

@aweell aweell closed this as completed Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants