Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] 相关Agent脚本统一用Go编译，降低维护成本 #688

Open
CohleRustW opened this issue Apr 18, 2022 · 2 comments
Open

[FEATURE] 相关Agent脚本统一用Go编译，降低维护成本 #688

CohleRustW opened this issue Apr 18, 2022 · 2 comments
Assignees
@zhangzhw8 @CohleRustW @ZhuoZhuoCrayon
Labels
kind/optimization 优化 milestones/nice to have 可以考虑的建议

Comments

@CohleRustW
Copy link
Collaborator

你想要什么功能

为什么需要
目前代码为支持不同操作系统安装，维护多套不同语言脚本，维护和理解成本较高

建议如何实现
@CohleRustW CohleRustW self-assigned this May 10, 2022
@CohleRustW
Copy link
Collaborator Author

CohleRustW commented May 30, 2022 •
edited
Loading

预期计划：

  1. 收拢相关安装过程中需要临时修改脚本的场景，评估可行性
  2. 完成对应安装过程Demo，这里可能会通过Rust实现
  • 要求一：多操作系统兼容展示
  • 要求二：代码可读性

待讨论问题：

  1. 是否沿用之前的逻辑，区分不同操作系统编译为不同的二进制文件，还是以windows或者是linux为区分，把代码尽可能的编译在同一个文件内
    • 区分编译会让整体的编译后文件更小
    • 代码全量编译更贴合安装工具概念，后续也可以在此基础上更好的拓展功能

@CohleRustW
Copy link
Collaborator Author

当前脚本问题记录：

  1. 获取操作系统类型逻辑get_os_info,匹配逻辑不严谨，/proc/version是在内核编译时获取的跟主机名相关的信息，所以主机名就变成了操作系统分类逻辑用途的字符串，需要重新设计

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhangzhw8 zhangzhw8

@CohleRustW CohleRustW

@ZhuoZhuoCrayon ZhuoZhuoCrayon

Labels
kind/optimization 优化 milestones/nice to have 可以考虑的建议
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zhangzhw8 @CohleRustW @ZhuoZhuoCrayon