Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(knapsack): fix icon rendering bug and add icon lockup #2286

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

bsahitya
Copy link
Collaborator

@bsahitya bsahitya commented Nov 27, 2024

Description

Issues in knapsack fixed in this PR:
Icons are not rendering in knapsack docs.
Code editor, notebook cell docs do not show up in the sidebar.

New additions:
Add docs for Icon lockup component

What's included?

  • Update knapsack metadata to fix icon bug.
  • Add notebook cell, code editor back to the docs site sidebar
  • Add docs for the new icon lockup component.

Test Steps

  • npx nx run knapsack:serve
  • then check icon, icon button and icon button toggle components
  • finally verify if icons are displayed in these components

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker
Screenshot 2024-11-27 at 11 20 10 AM Screenshot 2024-11-27 at 11 20 36 AM Screenshot 2024-11-27 at 11 20 46 AM Screenshot 2024-12-03 at 11 33 52 AM

@owilliams320 owilliams320 temporarily deployed to covalent-pip-docs-knaps-x4ecyt November 27, 2024 17:27 Inactive
@owilliams320 owilliams320 temporarily deployed to covalent-pip-docs-knaps-x4ecyt December 3, 2024 17:33 Inactive
@bsahitya bsahitya changed the title docs(knapsack): fix icon rendering bug docs(knapsack): fix icon rendering bug and add icon lockup Dec 3, 2024
@owilliams320 owilliams320 merged commit 9bb5d04 into main Dec 4, 2024
7 checks passed
@owilliams320 owilliams320 deleted the docs/knapsack-icon-bug branch December 4, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants