Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of windmills #14

Open
Josharias opened this issue Oct 9, 2016 · 3 comments
Open

Fix rendering of windmills #14

Josharias opened this issue Oct 9, 2016 · 3 comments
Labels
Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Status: Blocked Is currently blocked by missing dependencies, pre-requisites, etc. Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems

Comments

@Josharias
Copy link
Contributor

Josharias commented Oct 9, 2016 •
edited
Loading

To reproduce:

  1. get a windmill block
  2. get a windmill sail
  3. put the windmill sail into the windmill block's inventory
  4. It should show a nicely rendered sail, but instead it shows the item's icon.
  • Needs to not use the default icon rendering and instead just attach its own mesh.
  • Not sure if the custom item rendering thingy is useful anymore.
@skaldarnar
Copy link
Contributor

What do you refer to by "custom item rendering"? Should this be something
generally available to other modules?

On Sun, Oct 9, 2016, 23:11 Josh Zacharias [email protected] wrote:

  • Needs to not use the default icon rendering and instead just attach
    its own mesh.
  • Not sure if the custom item rendering thingy is useful anymore.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#14, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYbqizHJWBeCaGvpfVJB8ogplRDs1kDks5qyVibgaJpZM4KSHUl
.

@Josharias
Copy link
Contributor Author

"Custom item rendering" is part of a system from the ItemRendering module. CustomRenderedItemMeshComponent

@jdrueckert jdrueckert mentioned this issue Apr 30, 2022
Open
@jdrueckert jdrueckert added Type: Bug Issues reporting and PRs fixing problems Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. Status: Blocked Is currently blocked by missing dependencies, pre-requisites, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness labels Apr 30, 2022
@jdrueckert
Copy link
Member

This is currently blocked by #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Gameplay Content Requests, Issues and Changes targeting gameplay mechanics and content Status: Blocked Is currently blocked by missing dependencies, pre-requisites, etc. Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skaldarnar @Josharias @jdrueckert