-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable for a player to die if not killed by another player #145
Comments
Is anybody working on this issue, if not could I give this a try? |
Hey @ahv15 👋 Nope not aware of anybody working on this, feel free! |
hey @Cervator was hoping to work on some other issue in the mean time, I was actually not able to see any sort of a kill counter or a death counter after I had started the game , am I supposed to enable anything else in singleplayer so that I can see some sort of a kill or death counter |
Looks like you got an initial answer on Discord (wise choice to check there!), to add to that a little: the death counter is what you see if you get to where the game ends (after 5 points). I tend to just use With this issue resolved the player should be able to die normally and respawn, and for each time that happens their death counter visible on the game over screen should be one higher :-) |
Ohhk, I was wondering whether I would have to trudge across the map several times just to see the death counter once. Will make use of this handy hack then. |
Yep I can usually do it in 20 seconds or so. There's also a variable holding the number of rounds to win a game, you can drop that from 5 to 1 to make it even faster :-) |
@ahv15 hi 👋 thanks for working on the issue! tips to end the game quicker:
Edit: |
Actually having a K/D count appear within the game might be quite a nice addition 🤔 It really did slip my mind when working on the elements. Indeed it comes to a surprise when you see that there was a counter for that at the end of the game. |
@stefaniamak Thanks for the tips, actually few of the issues in this module seem to be related to the game over screen, hopefully if I gain a better understanding of how everything works I should be able to fix 2-3 issues in one go. |
Just wanted to ask if the player gets killed does he normally get teleported back to the base? I got the number of deaths to be updated but the player doesnt seem to get teleported. |
So is this a problem with the teleportation or does teleportation normally not happen? |
@stefaniamak Everything else works fine, as all the items are being dropped and the health is being restored and the death counter is also being updated but the teleportation part does not work. |
@ahv15 yes in multiplayer you get teleported to the base right away! It actually happens instantly (without a warning/notification like "you died!"), which is kind of odd tbh |
So does the teleportation part work only in multiplayer or is it supposed to work out even in singleplayer as I had tested it out in singleplayer? |
Maybe thats why i wasnt being teleported. |
I will give the multiple builds thing a try. |
I believe it is supposed to work on single-player too, as you can die alone at multy-player too 👍 |
The doubt arised as I saw no problem with the rest of the code , will try checking it out then. |
Nice to see such activity on this 😊 @ahv15 @stefaniamak where are we with this issue right now? |
@skaldarnar I haven't been able to do much for the past few weeks as my laptop is being repaired, but I am hoping to take a look at this and a few other things once it comes back. |
Oh noes, hardware failures are always bad 😕 good luck with the repair! |
Issue
When the player reaches 0 HP alone without being killed by another client (e.g. when they fall from the high ground), they do not die but continue playing normally.
Proposed solution for now
Have the player's
death
counter increase, without increasing theirkills
counter.The text was updated successfully, but these errors were encountered: