Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix arguments to ViewState #7204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjonsson
Copy link
Contributor

What this PR does

There are two arguments required
for ViewStateOptions, so put in
a second argument with an undefined
value which is what is used
at other call sites.

Test me

Test only changes.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@pjonsson pjonsson force-pushed the viewstateoptions-all-params branch from ab1e52b to 6e6f679 Compare June 23, 2024 18:28
@pjonsson pjonsson mentioned this pull request Jan 1, 2025
4 tasks
There are two arguments required
for ViewStateOptions, so put in
a second argument with an undefined
value which is what is used
at other call sites.
@pjonsson pjonsson force-pushed the viewstateoptions-all-params branch from 6e6f679 to 5e8005b Compare January 2, 2025 09:31
pjonsson added a commit to pjonsson/TerriaMap that referenced this pull request Feb 15, 2025
There are two arguments required
for ViewStateOptions, so put in
a second argument with an undefined
value which is what is used
at other call sites.

This mirrors the same change in terriajs:
TerriaJS/terriajs#7204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant