Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: use recommended configuration #7323

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Nov 21, 2024

What this PR does

The eslint-recommended configuration
is a subset of recommended, so switch
to the recommended configuration and
remove the rules that are already part
of the recommended configuration.
There are a few rules that result in
numerous errors, so disable them for
now.

Test me

Tested by CI.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@pjonsson pjonsson mentioned this pull request Nov 21, 2024
4 tasks
@pjonsson pjonsson force-pushed the no-unused-vars-fixes branch from c411855 to 9086616 Compare November 22, 2024 11:44
The eslint-recommended configuration
is a subset of recommended, so switch
to the recommended configuration and
remove the rules that are already part
of the recommended configuration.
There are a few rules that result in
numerous errors, so disable them for
now.
@pjonsson pjonsson force-pushed the no-unused-vars-fixes branch from 9086616 to 38b2923 Compare November 22, 2024 11:45
@pjonsson pjonsson changed the title ESLint: enable more unused vars checks ESLint: use recommended configuration Nov 22, 2024
@pjonsson pjonsson mentioned this pull request Dec 3, 2024
4 tasks
Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @pjonsson.

@na9da na9da merged commit a7fa8b3 into TerriaJS:main Dec 6, 2024
6 checks passed
@pjonsson pjonsson deleted the no-unused-vars-fixes branch December 6, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants