Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use encoding: false when copying files using gulp. #7340

Merged
merged 2 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Remove unused class-list dependency.
- TSify `ConsoleAnalytics` module.
- Update to gulp 5.0 to fix security vulnerabilities.
- Gulp 5 defaults to encoding copied files as utf-8, had turn off encoding by setting `encoding: false` to correctly copy binary assets from dependencies.
- Update to dompurify 2.5.7 to fix security vulnerabilities.
- Remove unused simple-statistics dependency.
- Update to pretty-quick 4.0.0 to fix security vulnerabilities.
Expand Down
9 changes: 6 additions & 3 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ gulp.task("copy-cesium-workers", function () {

return gulp
.src([path.join(cesiumWorkersRoot, "**")], {
base: cesiumWorkersRoot
base: cesiumWorkersRoot,
encoding: false
})
.pipe(gulp.dest("wwwroot/build/Cesium/build/Workers"));
});
Expand All @@ -95,7 +96,8 @@ gulp.task("copy-cesium-thirdparty", function () {

return gulp
.src([path.join(cesiumThirdPartyRoot, "**")], {
base: cesiumThirdPartyRoot
base: cesiumThirdPartyRoot,
encoding: false
})
.pipe(gulp.dest("wwwroot/build/Cesium/build/ThirdParty"));
});
Expand All @@ -109,7 +111,8 @@ gulp.task("copy-cesium-source-assets", function () {

return gulp
.src([path.join(cesiumAssetsRoot, "**")], {
base: cesiumAssetsRoot
base: cesiumAssetsRoot,
encoding: false
})
.pipe(gulp.dest("wwwroot/build/Cesium/build/Assets"));
});
Expand Down
Loading