We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, metrics produced by the SeaCat Auth are a bit illogical and should be refactored:
help
unit
^- these two may be about the implementation in the InfluxDB forwarded in ASAB, it is linked with Prometheus implementation.
sessions
anonymous_sessions
regular
anonymous
seacat-auth/seacatauth/session/algorithmic.py
Line 44 in 27011e0
seacat-auth/seacatauth/session/service.py
Line 84 in 27011e0
Proposed change:
self.AnonymousSessionCounter: asab.metrics.Counter = self.MetricsService.create_counter( "sessions", tags={"help": "Number of anonymous sessions created."}, init_values={"anonymous": 0} )
self.SessionGauge = self.MetricsService.create_gauge( "sessions", tags={"help": "Counts active sessions."}, init_values={"regular": 0} )
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Currently, metrics produced by the SeaCat Auth are a bit illogical and should be refactored:
help
attribute should be removed (at least from the propagation to InfluxDB)unit
attribute should be removed (at least from the propagation to InfluxDB)^- these two may be about the implementation in the InfluxDB forwarded in ASAB, it is linked with Prometheus implementation.
sessions
andanonymous_sessions
metrics should be unified into:sessions
:regular
/anonymous
.seacat-auth/seacatauth/session/algorithmic.py
Line 44 in 27011e0
seacat-auth/seacatauth/session/service.py
Line 84 in 27011e0
Proposed change:
The text was updated successfully, but these errors were encountered: