Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default show exec history only for active plans #289

Open
wants to merge 1 commit into
base: testlink_1_9_20_fixed
Choose a base branch
from

Conversation

heuj
Copy link
Contributor

@heuj heuj commented Nov 7, 2020

In larger projects (many test executions), loading the exec history window contents can take quite long time. Proposing to by default only show the results from active plans.

In larger projects (many test executions), loading the exec history window contents can take quite long time. Proposing to by default only show the results from active plans.
@fmancardi
Copy link
Contributor

would you mind to specify what do you mean for ... many test executions ... , 10, 100, 1000, 10000 ?

@fmancardi
Copy link
Contributor

default behaviour need to have a corresponding configuration option, not something forced in this way in the code

@heuj
Copy link
Contributor Author

heuj commented Nov 7, 2020

test executions (single test case):
only active plans in project: ~100
all plans in project: >1000

Loading time of execution history window all executions: ~50secs

I agree, likely there are more elegant ways of achieving this. Shall I close this request and open an improvement ticket in Mantis?

@fmancardi
Copy link
Contributor

Just checked that
http://mantis.testlink.org/view.php?id=7148 -> 0007148: TestLink doesn't show Execution History for test cases if those are the part of inactive test plans
This is related to accessing Execution History From test case specification.

seems to implement what you have explained.
Please would you mind to provide detailed steps to reproduce ?

@heuj
Copy link
Contributor Author

heuj commented Nov 8, 2020

Hi, thanks for the response!
Unfortunately I have difficulties with mantis login (cannot login w/ old credentials, pw reset / sign up mail not yet received), will retry.

Will try to explain in more detail until I can again access mantis:

  • first: I have no indication of malfunction/bug! It's only about convenience / performance
  • Execution history from Test Case Specification displays by default results from active plans only, but the user can choose to show all executions by unchecking the checkbox in the exec history pop up window. This works perfectly!
  • Execution history from other locations, e.g. from Test result matrix displays all executions active + inactive plans, the user can choose to only display active plans, but only after the window has finished loading.

I think in the first case the command opening the pop up is:
javascript:openExecHistoryWindow({$args_testcase.testcase_id},1);
in the other case, the second argument (1) is absent, which defaults to display all executions active+inactive.

In case the test case was executed very often (>1000) (and maybe has many attachments / lot of notes?! ), loading the execution history window takes much longer in case all executions, including the ones from inactive plans are selected.

Technically everything is ok, the window loads w/o issues, however I personally prefer to first get an overview quickly and only if needed wait longer to load the much older execution results.
That's the reason for the proposed "hack", which in case the openExecHistoryWindow function is called w/o second argument defaults to opening the window only w/ results from active plans (with the option to display all by unchecking the checkbox in the pop up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants