Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDSSpecifications - load method does not include all facet types in applicability and requirements #569

Open
5 tasks done
ogorhc opened this issue Feb 26, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@ogorhc
Copy link

ogorhc commented Feb 26, 2025

Describe the bug 📝

Description
While working with the load method in IDSSpecifications, I noticed that not all facet types are considered when parsing applicability and requirements. This may lead to missing facets when loading an IDS file.

BuildingSMART doc example

Issue
The method currently processes entity, attribute, classification, and property facets for the requirements and only entity for the applicability, but other facet types (material and partOf) are not included.
Expected behavior: The load method should support all possible facets defined in the IDS schema.

IDSSpecifications load method

applicability

requirements

Reproduction ▶️

No response

Steps to reproduce 🔢

No response

System Info 💻

System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
    Memory: 1.51 GB / 15.71 GB
  Binaries:
    Node: 20.11.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.22 - C:\Program Files\nodejs\yarn.CMD
    npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (130.0.2849.68)
    Internet Explorer: 11.0.22621.3527

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • Check that this is a concrete bug. For Q&A join our Community.
  • The provided reproduction is a minimal reproducible example of the bug.
@ogorhc ogorhc added the bug Something isn't working label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant