Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect duplicate bevy dependencies #15

Open
janhohenheim opened this issue Aug 30, 2024 · 5 comments · May be fixed by #185
Open

Detect duplicate bevy dependencies #15

janhohenheim opened this issue Aug 30, 2024 · 5 comments · May be fixed by #185
Labels
A-Linter Related to the linter and custom lints C-Feature Make something new possible

Comments

@janhohenheim
Copy link
Member

janhohenheim commented Aug 30, 2024

An issue that many beginners have when using Bevy is having duplicates of it within the dependencies. This usually happens when a user adds 3rd party crates that don't support the same major versions, such as one depending on Bevy 0.14 and the other depending on Bevy 0.13.

When this happens, users will get difficult error messages about type incompatibilities and conflicting versions, which can be really confusing! We should make a custom lint that specifically detects this in Cargo.lock and emits a clear error message on what happened and how to fix it.

@janhohenheim janhohenheim added A-Linter Related to the linter and custom lints C-Feature Make something new possible labels Aug 30, 2024
@BD103

This comment was marked as outdated.

@BD103
Copy link
Member

BD103 commented Sep 6, 2024

Just as a note, I edited Jan's original message as part of my issue-pass in #34.

@TimJentzsch
Copy link
Collaborator

Note that the compiler errors generated in these cases might get improved soon, then we might not need this lint anymore.
See Estaban Kuber's work on the error messages.

@BD103
Copy link
Member

BD103 commented Sep 8, 2024

Note that the compiler errors generated in these cases might get improved soon, then we might not need this lint anymore. See Estaban Kuber's work on the error messages.

Wonderful! @estebank is this something that can hit stable by November1? If so, I'll just close out this issue as not planned. (Also I know you said you're offline for 3 weeks, so no worries about responding immediately!)

Footnotes

  1. November is my deadline for getting bevy_lint released and useful.

@BD103 BD103 added this to the `bevy_lint` 0.2.0 milestone Oct 16, 2024
@BD103
Copy link
Member

BD103 commented Oct 16, 2024

This can be done relatively easily with find_crates(), adding it to the 0.2.0 milestone.

@DaAlbrecht DaAlbrecht linked a pull request Nov 27, 2024 that will close this issue
3 tasks
@BD103 BD103 linked a pull request Jan 28, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Related to the linter and custom lints C-Feature Make something new possible
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants