Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for windows #2

Open
matt-erhart opened this issue Jan 3, 2019 · 1 comment
Open

changes for windows #2

matt-erhart opened this issue Jan 3, 2019 · 1 comment

Comments

@matt-erhart
Copy link

matt-erhart commented Jan 3, 2019

process.on("uncaughtException", exception => {
  process.exit(appProc.pid); // switched kill to exit, else invalid pid error
  throw new Error(exception);
});

script should be something like this for webpack dev server

//start cmd defined then passed as arg[0]
    "start": "webpack-dev-server --mode development --hot --progress --color --port 3000 --open",
    "startWithCypress": "cross-env WAIT_FOR_MESSAGE=\"Compiled\"  cypressAppWatcher start"

then I changed the spawn command:

  appProc = spawn(/^win/.test(process.platform) ? 'npm.cmd' : 'npm', ['run',  myArgs[0]]);
@lgandecki
Copy link
Member

Hello @matt-erhart ! Thank you for giving this a try and sharing the feedback.
Unfortunately, I'm not sure what to do with this message.

Where is that first snippet of code that catches exceptions from?

The second part - do I understand correctly that the cross-env is needed for windows?

The spawn command - is this (and maybe updated docs with a section for windows?) something you could send us a PR for? I'd really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants