Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video is not converted into specified file-format #245

Open
VanillaChief opened this issue Oct 26, 2024 · 15 comments
Open

Video is not converted into specified file-format #245

VanillaChief opened this issue Oct 26, 2024 · 15 comments
Labels
request type/bug Something isn't working

Comments

@VanillaChief
Copy link

Bug Information

Bug Description

When attempting to convert a video file using HandBrake Web, the application fails to convert the file to the specified format. I expect the file to be saved in the chosen video format, but the output remains unchanged, as if the conversion settings were ignored. I am not sure if I set it up wrong or something is actually not working right. Please advise.

Bug Steps

  1. Import Preset, which specifies that the file should be converted to mp4
  2. Watcher set up with this preset finds a .mkv files
  3. After conversion, the output is still mkv
  4. When using the preset with Handbrake Desktop, it works like expected

Additional Information

Screenshot 2024-10-26 at 08 48 59 Screenshot 2024-10-26 at 08 49 06 Screenshot 2024-10-26 at 08 49 18

Application Information

HandBrake Web Version

  • v0.7.1

Docker Compose

services:
  handbrake-server:
    image: ghcr.io/thenickoftime/handbrake-web-server:latest
    container_name: handbrake-web-server
    user: 1000:1000 # edit to run as user (uuid:guid) with permissions to access your media. 0:0 to run as root (not recommended).
    ports:
      - 8994:9999
    volumes:
      - ./data:/data
      - ./media:/video # ensure this path is the same across all containers
      - ./output:/output

  handbrake-worker:
    image: ghcr.io/thenickoftime/handbrake-web-worker:latest
    container_name: handbrake-web-worker
    user: 1000:1000 # edit to run as user (uuid:guid) with permissions to access your media. 0:0 to run as root (not recommended).
    environment:
      - WORKER_ID=handbrake-worker # give your worker a unique name
      - SERVER_URL=xxx.xxx.xxx.xx # change if setting up a standalone worker, prefix with http(s):// if necessary
      - SERVER_PORT=8994 # change if using a reverse proxy or the port is otherwise different than above
    volumes:
      - ./media:/video # ensure this path is the same across all containers
      - ./output:/output
    depends_on:
      - handbrake-server

Host Machine

  • OS: Debian 12
  • CPU: i7-8700T
@VanillaChief VanillaChief added request type/bug Something isn't working labels Oct 26, 2024
@TheNickOfTime
Copy link
Owner

Sorry for the late response, I've been slammed with work lately. Could you provide some log output from the worker handling this? It should hopefully reveal what is going on here. You should be able to download the log for the failed job from the queue interface:
image

If that isn't available for some reason, you can access worker logs from the the data/log directory of your mounted data path

@eltiel
Copy link

eltiel commented Nov 15, 2024

I have the same problem.

image
image

Log attached: worker1-job-5.log

@TheNickOfTime
Copy link
Owner

Thank you for the log! I'll take a look to see what's going on. I'll prioritize this fix and push it in a v0.7.2 patch version - hopefully by the end of this weekend. Development is attached to issue #248.

@TheNickOfTime
Copy link
Owner

I had some time today to fix the issue, and have published the fix with release v0.7.2. Just pull the latest docker images and you guys should be good to go!

@KucharczykL
Copy link

Hi, I have only started using handbrake-web after 0.7.2 was released (and checked that I am indeed running 0.7.2) but I am also having this issue.

@TheNickOfTime
Copy link
Owner

Could you drop a log as mentioned above? Probably another edge case where this can occur.

@KucharczykL
Copy link

Here's the log:

handbrake-worker-devilfish-job-23.log

@eltiel
Copy link

eltiel commented Nov 21, 2024

Hi, I have only started using handbrake-web after 0.7.2 was released (and checked that I am indeed running 0.7.2) but I am also having this issue.

Same here. In 0.7.2 didn't fix the issue it seems

@TheNickOfTime
Copy link
Owner

Thanks for the logs and reports, will look back into this, thank you for your patience!

@TheNickOfTime
Copy link
Owner

Just to clarify, the issue that you are still experiencing is that the file output is not using the file extension that is specified in your preset?

There is a bit of a conflict in the way that the CLI handles extensions vs the desktop version of handbrake - the CLI uses the extension specified in your output path, whereas the desktop version of HandBrake will use what is stored in the preset. Currently this application ignores what is in the preset, and uses what is manually specified when creating a job.

@eltiel
Copy link

eltiel commented Nov 21, 2024

Just to clarify, the issue that you are still experiencing is that the file output is not using the file extension that is specified in your preset?

Yes

There is a bit of a conflict in the way that the CLI handles extensions vs the desktop version of handbrake - the CLI uses the extension specified in your output path, whereas the desktop version of HandBrake will use what is stored in the preset. Currently this application ignores what is in the preset, and uses what is manually specified when creating a job.

I use watchers instead of manually creating a job, so I don't get to specify the extension.

@TheNickOfTime
Copy link
Owner

Cool - must have forgotten to add the extension select to the watcher creation process. I'll push a 0.7.3 release soon that allows you to specify the extension for watchers (#257). Then, for v0.8 I will make it so a preset's extension is respected first, then you can override it if desired (#258).

@KucharczykL
Copy link

KucharczykL commented Nov 22, 2024

Ah, that's right, I did forgot to mention I also use a watcher. Makes sense now. Thanks for looking into it!

@TheNickOfTime
Copy link
Owner

I just published v0.7.3 that should fix this issue well enough for now! Essentially watchers will use whatever extension is defined in their preset for the time being. I will be reworking how output extensions are handled for v0.8.0.

@KucharczykL
Copy link

I updated and converted one video and the problem seems to be fixed. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants