Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang 19 Breakage #125

Closed
TheNitesWhoSay opened this issue Oct 6, 2024 · 3 comments · Fixed by #127
Closed

Clang 19 Breakage #125

TheNitesWhoSay opened this issue Oct 6, 2024 · 3 comments · Fixed by #127

Comments

@TheNitesWhoSay
Copy link
Owner

Inclusion of reflect.h generally fails on clang 19.1.0 https://godbolt.org/z/PcEoK4j5M

@TheNitesWhoSay
Copy link
Owner Author

At the same time running into the same issue as actions/runner-images#10018 on my local

@TheNitesWhoSay
Copy link
Owner Author

The latter issue is an environment issue not a code issue (the code still works on older clang versions, just not with newer MSVC STL releases), I chose to update my LLVM version locally (which for me meant taking a newer download from https://github.com/llvm/llvm-project/releases/ ), but there are other approaches that may be more appropriate in other peoples cases. Now back to working on the OP.

@TheNitesWhoSay
Copy link
Owner Author

Seems to accept the very simple fix: https://godbolt.org/z/vvohhdfWb
86b141a

Couldn't find any breakages with newer compiler version nor newer C++ standards so going ahead with a release.

This was referenced Oct 6, 2024
@TheNitesWhoSay TheNitesWhoSay linked a pull request Oct 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant