Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split all translation units into C files #127

Open
TheOnlyZac opened this issue Nov 23, 2024 · 0 comments
Open

Split all translation units into C files #127

TheOnlyZac opened this issue Nov 23, 2024 · 0 comments
Labels
help wanted Extra attention is needed matching Progress for matching a function or file

Comments

@TheOnlyZac
Copy link
Owner

TheOnlyZac commented Nov 23, 2024

There are numerous translations units which have not yet been split into C files with splat. In the splat config (config/sly1.yaml), under "P2 sources", there is a line for each translation unit. The type is either asm or c.

    - [0x61070, c, P2/game]    # C split
    - [0x61e80, asm, P2/geom]  # ASM split
    #- [0x, asm, P2/gifs]      # Not split

The commented-out splits are because we have not identified the start address of that translation unit. Once it has an address, it can be uncommented and the type set to asm.

The asm splits can be changed to c splits once all (or most, but preferably all) functions in that file have been identified, and their signatures added to symbol_addrs.txt. After changing the split from asm to c, a .c file will be generated in P2/src and auto-populated with INCLUDE_ASM macros.

All c splits should already have .c files, and those files are ready for function matching.

@TheOnlyZac TheOnlyZac added matching Progress for matching a function or file help wanted Extra attention is needed labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed matching Progress for matching a function or file
Projects
None yet
Development

No branches or pull requests

1 participant