Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem while reproducing referit dataset #9

Open
YBYBZhang opened this issue Oct 20, 2020 · 3 comments
Open

problem while reproducing referit dataset #9

YBYBZhang opened this issue Oct 20, 2020 · 3 comments

Comments

@YBYBZhang
Copy link

Thank you for your great work. I meet some problems when I reproduced the result on referit dataset. I use the same config with this file.
However, the validation accuracy is only 50% after 20 epochs while it should be 58% in the paper. I think maybe the config is different among different datasets. Looking forward to your help !

@TheShadow29
Copy link
Owner

Hello, @1170300521 sorry for the delayed reply (for some reason this didn't turn up in my notifs).

I recall using lr=1e-4 for 10 epochs, and 1e-5 for another 10 epochs.

I might have access to the logs, so let me know if you are having trouble reproducing the result.

@tejan-rgb
Copy link

tejan-rgb commented Sep 26, 2021

@1170300521 @TheShadow29 I am having difficulty reproducing the result. I am trying to reproduce the result on Flickr30k.
Everything went fine till...

I ran python code/main_dist.py flickr30k_retina_29Jul19.pth --ds_to_use='refclef' --resume=True --only_valid=True --only_test=True

and got an error:

Traceback (most recent call last):
  File "code/main_dist.py", line 101, in <module>
    fire.Fire(main_dist)
  File "/home/tejanm/anaconda3/lib/python3.8/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/home/tejanm/anaconda3/lib/python3.8/site-packages/fire/core.py", line 466, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/home/tejanm/anaconda3/lib/python3.8/site-packages/fire/core.py", line 681, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "code/main_dist.py", line 83, in main_dist
    cfg = update_from_dict(cfg, kwargs, key_maps)
  File "/home/tejanm/zsgnet-pytorch/code/extended_config.py", line 83, in update_from_dict
    assert subkey in d, f'key {full_key} doesnot exist'
AssertionError: key only_valid doesnot exist

Can you please help?

@TheShadow29
Copy link
Owner

@tejan-rgb Can you try changing only_valid to only_val?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants