Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using an enum of all screens #15

Open
TheSuperGamer20578 opened this issue Jan 10, 2023 · 0 comments
Open

Stop using an enum of all screens #15

TheSuperGamer20578 opened this issue Jan 10, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@TheSuperGamer20578
Copy link
Owner

Problem/Use Cases

Using an enum of all screens is overly verbose, requires an update every Minecraft update, and if maintained could cause compatibility issues. It also makes mod compatibility hard if not impossible.

Feature

Replace the enum of screens and the accompanying switch statement with a JSON file — which may be altered with resource packs for mod support.

Alternatives

Simply removing all screens that do the same thing as Screens.OTHER or are redundant due to inheritance would help and might be a good idea in the short term but this doesn't address the problem of compatibility with older Minecraft versions after a new screen that needs to be handled is added or mod compatibility.

Additional Context

Using screen names will be problematic due to names being obfuscated. A similar system should be used for #2 and potentially for #10.

@TheSuperGamer20578 TheSuperGamer20578 added the enhancement New feature or request label Jan 10, 2023
@TheSuperGamer20578 TheSuperGamer20578 self-assigned this Jan 10, 2023
TheSuperGamer20578 added a commit that referenced this issue Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant