Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default layout contains nested footer elements #75

Open
michaelwood opened this issue Apr 26, 2022 · 0 comments
Open

Default layout contains nested footer elements #75

michaelwood opened this issue Apr 26, 2022 · 0 comments

Comments

@michaelwood
Copy link
Member

https://cdn.threesixtygiving.org/components/detail/layout--default.html

Valid html test failed - 4: error: The element “footer” must not appear as a descendant of the “footer” element.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/footer

(Solution used in cove dataquality to pass tests is to switch the top container element into a div)
michaelwood added a commit to ThreeSixtyGiving/dataquality that referenced this issue Apr 26, 2022
@michaelwood
cove: footer: Fix nested footer elements issue
8c419a3 
Related: ThreeSixtyGiving/360-ds#75
michaelwood added a commit to ThreeSixtyGiving/dataquality that referenced this issue Apr 26, 2022
@michaelwood
cove: footer: Fix nested footer elements issue
4c9e814 
Related: ThreeSixtyGiving/360-ds#75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelwood